Peter Hunt

Results 1092 comments of Peter Hunt

no problem, school comes first :) good luck on exams!

I think this PR doesn't make sense right now. I think we'd want an alternate way for container's to specify ambient caps, ideally with proper pod API support in kube....

good initiative! yeah please feel free to open child issues and begin breaking down the issue

@hasan4791 can you take this one over?

> > @hasan4791 can you take this one over? > > On a bike trip for 2 weeks :grin: :partying_face: Will take this one if its still available +1 enjoy!

I actually think the approach here should be different. instead of applying allowed annotations as a config flag, I think we should add a `default_workload` field similar to `default_runtime` and...

instead of this approach, I think the config should look something like: ``` [crio.runtime] default_workload = "xyz" [crio.runtime.workloads.xyz] allowed_annotations = "abc" ```

> Little confusion here, does the value for default_workload is set by user or do we need to provide something? Also whats the need of this new field though the...

I think we can close this! default allowed annotations can be applied as above