mechvibes icon indicating copy to clipboard operation
mechvibes copied to clipboard

Added dark mode support with a checkbox

Open karimk123 opened this issue 4 years ago • 5 comments

I added a checkbox with for enabling and disabling dark mode and added the functionality. Of course, dark colors, position of the checkbox can all be improved but focused more on the functionality itself and hopefully its gets accepted.

karimk123 avatar Dec 17 '20 23:12 karimk123

Can you show a screenshot of how it looks now? @karimk123

max-programming avatar Jan 16 '21 14:01 max-programming

Can you show a screenshot of how it looks now? @karimk123

I dont have my laptop on me right now, could you please try it on your end and see how it looks like?

karimk123 avatar Jan 16 '21 15:01 karimk123

Can you show a screenshot of how it looks now? @karimk123

I dont have my laptop on me right now, could you please try it on your end and see how it looks like?

Ok I'll try

max-programming avatar Jan 16 '21 15:01 max-programming

What do you think?

karimk123 avatar Jan 17 '21 16:01 karimk123

What do you think?

Where are the screenshots? I would like to see it. Please add some.

iammursalin avatar Jan 21 '22 14:01 iammursalin

It doesn't look like this does anything in terms of storing the setting, so everytime the app restarts your choice will reset to default. I might re-implement this using the new checkbox CSS I added in #247

NotLazy avatar Oct 19 '23 04:10 NotLazy