hail icon indicating copy to clipboard operation
hail copied to clipboard

Published 20 hours ago • verified publisher icon hail-is

[batch] Open Batches!

Open jigold opened this issue 1 year ago • 8 comments

Based off of #12154. Stacked on #12193.

jigold avatar Sep 19 '22 14:09 jigold

@daniel-goldstein Let's see if the tests pass now, but should be really close!!!

jigold avatar Sep 20 '22 19:09 jigold

I forgot to add the UI time_updated field... Will do so now.

jigold avatar Sep 20 '22 19:09 jigold

I put the time_updated field in. I'll test it with dev deploy once everything else is ready to go.

jigold avatar Sep 20 '22 19:09 jigold

Stacked on #12208

jigold avatar Sep 20 '22 21:09 jigold

Note to self to check the logs for error messages before merging!

jigold avatar Sep 21 '22 17:09 jigold

I changed that the _update_token is no longer cached. I thought it was the source of a bug, but it was something else that was an issue. However, I felt it was confusing and I didn't see what value it provided as we have retries on all of our client operations that would need the token and the token is not used in future operations to submit the update.

jigold avatar Sep 22 '22 20:09 jigold

duh you're totally right, I don't know why I thought retrying was happening higher up and not further down in the http client.

daniel-goldstein avatar Sep 22 '22 20:09 daniel-goldstein

Sorry this was a lot more broken than I thought. I didn't remember everything I stripped down for the previous PRs and didn't add back in. The commit update and update-fast endpoints need to return the start_job_id. Hopefully that's the last of these issues

daniel-goldstein avatar Sep 22 '22 20:09 daniel-goldstein