geom_boxplot

[ammekk]

Added a geom to support boxplots.

[johnc1231]

Ok, so the main problem with this PR is that it uses precomputed, which doesn't respect faceting right now. So it'll end up plotting the same plot on each facet since it'll just compute the overall quantiles once.

[danking]

@tpoterba we'll need a champion and a reviewer for this one as well

[danking]

@patrick-schultz , does this PR have a path to merging or does it require a rethink of our ggplot implementation? If the former, perhaps we could pull Iris in to finish this?

[patrick-schultz]

I haven't had a chance to look into this and understand how precomputed and faceting work and interact. If Iris wants to give that some thought, I'd be happy to advise. If there is a real obstruction to doing this in the current design, it would be good for both Iris and I to understand it before starting a redesign.

[ammekk]

Thats a great point

---

From: Patrick Schultz @.> Sent: Tuesday, October 4, 2022 7:27 AM To: hail-is/hail @.> Cc: Emma S Kelminson @.>; Author @.> Subject: Re: [hail-is/hail] geom_boxplot (PR #11720)

CAUTION: EXTERNAL SENDER

I haven't had a chance to look into this and understand how precomputed and faceting work and interact. If Iris wants to give that some thought, I'd be happy to advise. If there is a real obstruction to doing this in the current design, it would be good for both Iris and I to understand it before starting a redesign.

— Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhail-is%2Fhail%2Fpull%2F11720%23issuecomment-1266817118&data=05%7C01%7Cemma.kelminson001%40umb.edu%7Cf12d7220658149a9bc7a08daa5fb7ba4%7Cb97188711ee94425953c1ace1373eb38%7C0%7C0%7C638004796790915105%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dry2ZdLcd1beO2WrdhCRT9sV0kjtFm4lKsy2nL0iqnU%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARVGM3NWM6AEALMGZIZ2WS3WBQIDVANCNFSM5SGPPZUA&data=05%7C01%7Cemma.kelminson001%40umb.edu%7Cf12d7220658149a9bc7a08daa5fb7ba4%7Cb97188711ee94425953c1ace1373eb38%7C0%7C0%7C638004796791071348%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iR6L6EoWRp6CivnjxCyKhe%2Bjs%2FYl2p29e%2FVbCxYxgvQ%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

[danking]

@iris-garden reopen if this is still a relevant PR to your work