Haikal Ryclova-Pribadi

Results 94 comments of Haikal Ryclova-Pribadi

I think we need to take inspiration from `bazel-deps`, @lolski. We can see in [`//dependencies/maven/dependencies.bzl`](https://github.com/graknlabs/grakn/blob/master/dependencies/maven/dependencies.bzl) that it generates the list of dependencies through one final function: ``` def maven_dependencies(callback =...

I feel like this will be quite a bit of work. Do we need it for 1.5 release, @lolski @vmax ? Otherwise, we can work on it after we release...

Okay. How far is it from "ideal" right now? But most importantly: do we even still need or want to create a macro for dependencies of a given repo to...

Okay then I'd say lets put this on the back burner for now, @lolski @vmax. We can tidy up the organisation of the dependency declaration in the `WORKSPACE` file as...

I'm not sure if we have ever covered this, but it seems like `@stackb_rules_proto` are doing exactly what we're trying to achieve in this issue? Let's say we way to...

I tried implementing this strategy for `@graknlabs_protocol`, and declared all the dependencies in `//:deps.bzl`. ``` load("@graknlabs_build_tools//grpc:dependencies.bzl", "grpc_dependencies") load("@com_github_grpc_grpc//bazel:grpc_deps.bzl", "grpc_deps") load("@stackb_rules_proto//java:deps.bzl", "java_grpc_compile") def graknlabs_protocol_deps(**kwargs): grpc_dependencies(**kwargs) grpc_deps(**kwargs) java_grpc_compile(**kwargs) ``` When I tried...

One idea to try out in the future is to have the macro of a given repository to load the macro of its dependency first; i.e. a recursive macro declaration...

> If the match-inserts don't contain employments and companies, the final answer is 64 as expected What do you mean by the above, @alexjpwalker ? Can you give an example...

I have reproduced the issue above, and I can confirm that this is actually EXPECTED BEHAVIOUR, @alexjpwalker. Basically, what's happening is... Answers that are returned from the `match` pattern are...

Deprioritised into Backlog, @flyingsilverfin. Also, don't put backticks in the title. Titles should be clean, simple and short