N. Haiat

icon location student at BGU, Israel

Results 14 comments of N. Haiat

Metric.ndcg score

I see a failed check on test coverege

ENH change Ridge tol to 1e-4

Good job @lorentzenchr

Look at lgtm.com alerts for last couple of months

Hi, for new ones wanting to help there are currently 8 errors to fix here: https://lgtm.com/projects/g/scikit-learn/scikit-learn/alerts/?mode=list&severity=error Note that LGTM is shutting down on December 16th 2022

ENH add new common test: `test_negative_sample_weight_support` and `allow_negative_sample_weight` tag

> I wonder if we should assume that negative weight work by default. I don't really see a valid use case for negative weights and don't want to enforce complexity...

Cosine distance and L1-norm for KMeans

> Thank you @mattilyra for this work. It makes sense considering K-medians for integration. Unfortunately, the code have significantly changed since you initially submitted this PR. Also the current K-Means...

Fix KNNImputer missing indicator column addition when add_indicator=True

Hoping this will be merged soon! Thank you for this PR

Clarification in the paper

If all is well can this issue be closed?

dumb number tokenisation

I feel like @FunPineapple 's approach to putting equations into another system would be better. I am not sure what WizardLM does. Can anyone provide us with more information?

CMD closes after I select WizardLM as my model.

Maybe it is the same error as this? https://github.com/nlpxucan/WizardLM/issues/14 Where someone suggested adding `--model llama`

Remove "As an AI language model..." from dataset.

Should we remove all "aligned" responses? I believe models do have limitations and sometimes it is best to let the user know about the the limitations of the model instead...