github icon indicating copy to clipboard operation
github copied to clipboard

`github` doesn't add itself to the package list

Open bquistorff opened this issue 2 years ago • 4 comments

I did a fresh install of github and used it to install rcall. During the installation process its dependency.do queried for the github version, which isn't in the dataset, giving the following error:

. quietly github version github
github package was not found

I'm not sure if this is a rcall or github issue.

bquistorff avatar Sep 22 '21 01:09 bquistorff

Did you use github to install github? Say, github install haghish/github. If you do, it works fine.

image

@bquistorff

randrescastaneda avatar Apr 26 '22 16:04 randrescastaneda

No, I did a net install following the instructions).

bquistorff avatar Apr 26 '22 16:04 bquistorff

Right. The problem is that github version reads from file g/github.dta , which is updated with the subcommand githubdb add. This subcommand is executed inside github install right after the Stata package is installed using net install. One solution is suggest the following in the instructions

net install github, from("https://haghish.github.io/github/")
github install haghish/github

or

net install github, from("https://haghish.github.io/github/")
githubdb add, address("haghish/github") username("haghish")  ///
		              reponame("github") name("github")

I know. It is overkill, but I don't see another way to solve it.

randrescastaneda avatar Apr 29 '22 20:04 randrescastaneda

If they are feasible, a few other options that don't require user changes could be:

  • github version has a special check for github.
  • github version (or any other command that depends on the info), first checks if it's listed in g/github.dta and if not, does the githubdb add.

bquistorff avatar Apr 29 '22 23:04 bquistorff