Roman Khavronenko
Roman Khavronenko
https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6252 has been merged and will be included into the next release.
@wasim-nihal do you need TLS support for your case? Do you write to local or remote syslog? Would it make sense to keep UDP as the only supported network?
Hi @wasim-nihal! Sorry for late reply! I got push back from @valyala for using 3rd-party lib. If this integration will be added, the client lib should be implemented internally. One...
Looks good! I'd simplify the design a bit by replacing ring buffer with golang channel. This would be much easier in development and will provide a similar capability: 1. Logs...
@dima-vm @f41gh7 would appreciate your feedback on this
Hello @wasim-nihal! > However, this practice exposes credentials, which is against our organizational security policies. The suggested solution is to introduce new flags to specify the secrets. But isn't it...
@wasim-nihal wdyt about changing `-snapshot.createURL` type to `flagutil.NewPassword`? https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/lib/flagutil/password.go With this change, `-snapshot.createURL` will get the following abilities: 1. Its content will be secured in log outputs 2. It will...
> Is it okay if I open a PR with this change? Sure! Will appreciate it!
As discussed [here](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/6152#issuecomment-2074794675), auth token still can be exposed in logs even if set via cmd-line flag. The proper solution would be to make vmstorage and vmsingle to read auth...
@aluode99 it is waiting its turn to be reviewed) I'd like for it to get merged)