David Beaumont
David Beaumont
I guess there's a chance I started writing this bit of API before Flogger bumped to 1.7 and I'm misremembering which version was causing the issue. It's been internally available...
The Android work is internal to Google and not open sourced.
At the very least, passing "null" to `withTags()` / `withLogLevelMap()` should be a synonym for passing `Tags.empty()` / `LogLevelMap.create(OFF)` to avoid accidentally allowing methods to (sometimes) be callable twice. And...
My recommendation is: 1. Revert the change to `withTags()` and document that `Tags.empty()` exists. 2. Add a `LogLevelMap.noOp()` singleton getter method and document that in `withLogLevelMap()` 3. Add a `isNoOp()`...
I'd still be interested to know where someone has a dynamically set level map which might be "no level map". I don't disbelieve it's possible but I did think about...