repub icon indicating copy to clipboard operation
repub copied to clipboard

Reset the sent message

Open hroberts65616 opened this issue 10 months ago • 8 comments

After I click on the icon to send it to my remarkable it shows sent over the icon. However when I go to the next web page, it still shows as sent. when I am sending multiple webpages to the remarkable for reviewing later, I have to stop and look at the remarkable, to see if I sent that page already.

Can it be configured so that when I go to the next webpage the sent message goes away.

Thanks,

hroberts65616 avatar Feb 24 '25 17:02 hroberts65616

I actually had this idea at one point and gave up because I couldn't decide how best to handle it. Here are a few options, I'm curious what match what you want most:

  1. only clear on "sent" or "err", e.g. if it's still converting, than navigating will preserve the status and keep updating, but if it's finished, it just serves as a clear. I think this is probably the easiest and closest to what you want. I don't think I came up with it last time.
  2. clear on navigation, e.g. no matter what's happened, clear the state, don't show further progress. I think this is a little harder to do, but as I type this, I'm not sure.
  3. remember state by url, e.g. if you navigated away and back, it would remember the state of the url (up to some timeout). I think this is ultimately what I wanted, and this is both difficult and can't be done super easily, but I wanted to include it for completeness.

Let me know if one of these captures what you had in mind, or if you actually meant something else. Depending on what, it might not be hard, and I think it should probably be the correct behavior.

One other downside is that enabling this does require another chrome permission, because chrome doesn't let you just be aware of navigation events, you have to observe contents too. I hope the fact that this is open source helps, but it's a small negative.

erikbrinkman avatar Feb 25 '25 01:02 erikbrinkman

If still converting it is counting up. This is good. If it err's then it sends a notification should stay.

If it is sent, can it timeout after 5-10 seconds and then clear?

Or as part of clicking on the link it saves the url in a variable. And checks it every 10-15 seconds. If the url and the variable give a false clear the sent message.

Thoughts?

On Mon, Feb 24, 2025, 7:24 PM Erik Brinkman @.***> wrote:

I actually had this idea at one point and gave up because I couldn't decide how best to handle it. Here are a few options, I'm curious what match what you want most:

  1. only clear on "sent" or "err", e.g. if it's still converting, than navigating will preserve the status and keep updating, but if it's finished, it just serves as a clear. I think this is probably the easiest and closest to what you want. I don't think I came up with it last time.
  2. clear on navigation, e.g. no matter what's happened, clear the state, don't show further progress. I think this is a little harder to do, but as I type this, I'm not sure.
  3. remember state by url, e.g. if you navigated away and back, it would remember the state of the url (up to some timeout). I think this is ultimately what I wanted, and this is both difficult and can't be done super easily, but I wanted to include it for completeness.

Let me know if one of these captures what you had in mind, or if you actually meant something else. Depending on what, it might not be hard, and I think it should probably be the correct behavior.

One other downside is that enabling this does require another chrome permission, because chrome doesn't let you just be aware of navigation events, you have to observe contents too. I hope the fact that this is open source helps, but it's a small negative.

— Reply to this email directly, view it on GitHub https://github.com/hafaio/repub/issues/17#issuecomment-2680122365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT4RP2FJMWFCZJBE4J5S4R32RPA4DAVCNFSM6AAAAABXYSW5NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBQGEZDEMZWGU . You are receiving this because you authored the thread.Message ID: @.***> [image: erikbrinkman]erikbrinkman left a comment (hafaio/repub#17) https://github.com/hafaio/repub/issues/17#issuecomment-2680122365

I actually had this idea at one point and gave up because I couldn't decide how best to handle it. Here are a few options, I'm curious what match what you want most:

  1. only clear on "sent" or "err", e.g. if it's still converting, than navigating will preserve the status and keep updating, but if it's finished, it just serves as a clear. I think this is probably the easiest and closest to what you want. I don't think I came up with it last time.
  2. clear on navigation, e.g. no matter what's happened, clear the state, don't show further progress. I think this is a little harder to do, but as I type this, I'm not sure.
  3. remember state by url, e.g. if you navigated away and back, it would remember the state of the url (up to some timeout). I think this is ultimately what I wanted, and this is both difficult and can't be done super easily, but I wanted to include it for completeness.

Let me know if one of these captures what you had in mind, or if you actually meant something else. Depending on what, it might not be hard, and I think it should probably be the correct behavior.

One other downside is that enabling this does require another chrome permission, because chrome doesn't let you just be aware of navigation events, you have to observe contents too. I hope the fact that this is open source helps, but it's a small negative.

— Reply to this email directly, view it on GitHub https://github.com/hafaio/repub/issues/17#issuecomment-2680122365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT4RP2FJMWFCZJBE4J5S4R32RPA4DAVCNFSM6AAAAABXYSW5NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBQGEZDEMZWGU . You are receiving this because you authored the thread.Message ID: @.***>

hroberts65616 avatar Feb 25 '25 03:02 hroberts65616

This one would be the best I think: only clear on "sent" or "err", e.g. if it's still converting, than navigating will preserve the status and keep updating, but if it's finished, it just serves as a clear. I think this is probably the easiest and closest to what you want. I don't think I came up with it last time.

If converting, and I navigate away. it is my fault for not waiting till it finished. If it err, then I also get a notification in the bottom right of the screen. again. my fault if I don't resolve the err.

If sent is displayed, and I navigate away, clear it right away.

hroberts65616 avatar Feb 26 '25 17:02 hroberts65616

Okay, so I took a look this morning, and I realized all of the code was there to clear on navigation, including some somewhat fancy that should have had the following effect: if you navigate while processing it will wait a half second after it's finished and then clear the tag.

I just pushed a small update that if it's finished it clears immediately. This might not be the ideal solution as now if it errors, that will also clear, but it does mean that if it's done and you navigate, it should clear. Anyway, wait until you can update to 5.1.1 and then see if this works. If not maybe there's something else going on, and it's actually a bug 😅

erikbrinkman avatar Mar 02 '25 16:03 erikbrinkman

@hroberts65616 5.1.1 is published now. Give it a shot!

erikbrinkman avatar Mar 04 '25 13:03 erikbrinkman

It seems like you're still having issues with this. This is the behavior that I see currently:

https://github.com/user-attachments/assets/a2266ffe-31fb-4aa7-b5b4-aa03262f30f7

which shows "sent" being cleared after navigating away. I'm guessing you're seeing different behavior? What is not happening the way you expect / what experiments are you trying?

erikbrinkman avatar Apr 06 '25 17:04 erikbrinkman

Version 5.3.0 of the app works much better, and I have not had any issues. As soon as I navigate to another page, the sent message clears. I also have not received the error message yet

hroberts65616 avatar May 15 '25 17:05 hroberts65616

That's so strange, since nothing in relation to that should have changed substantially... still, I'm glad that it's working well!

erikbrinkman avatar May 15 '25 17:05 erikbrinkman

Seems like this is mostly working, but reopen if its not.

erikbrinkman avatar Nov 29 '25 14:11 erikbrinkman