haf
Add option to skip printing skipped tests + fix FsCheck3 replay
Resolves #453 : https://github.com/haf/expecto/pull/511/commits/79f6e21881ae566036a22bbf0f1879454bf5784a
Also fixes the replay config so fscheck 3 will skip directly to the failing case: https://github.com/haf/expecto/pull/511/files/79f6e21881ae566036a22bbf0f1879454bf5784a..701746a1b3a2773ab9a011b221ce15e2f9345d0e
Alright. I'm back and starting to give this a look.
I think these are distinct work items that should be considered separately. Trying to review them together muddies the picture of what's going on with either
I see motivations for skipping skip messages in #453. Could you explain the perceived fix to FsCheck replay?
Yeah my bad should have made two PRs. I updated the description with links to the diffs for the two changes
Could you explain the perceived fix to FsCheck replay?
In FsCheck3 they seem to have added (or maybe factored out) a size parameter for replay in addition to the seed. Without the size, replay was playing all test inputs leading up to the failure; this change allows skipping directly to the failing test input
That makes sense. Skipping right to the broken case would be good for debugging.
I noticed that you also changed from printing the original seed to the final seed. I'm unsure how that impacts users focused more on deterministically repeating a specific run. Expecto itself has some tests that use the seed that way
This fell off my radar. Apologies.
I would need these work items to be split before merging either. A clean is history for future context is very important for a community maintained package like this.
From what I've see so far
- The Replay changes seem good
- Not printing skipped test messages has me a bit more worried. There's already some challenging interactions/interdependence between the config and the printers. I'll need to consider it and alternative approaches more carefully