expecto icon indicating copy to clipboard operation
expecto copied to clipboard

Rider Support?

Open varon opened this issue 5 years ago • 32 comments

Jetbrains has had the issue outstanding for 2 years now. https://youtrack.jetbrains.com/issue/RIDER-7172

Is there anything we can do on expecto's side to get stuff to work?

varon avatar May 06 '19 08:05 varon

2nd. Would be very nice to have! Much needed, especially since Rider doesn't understand that let main argv is the last declaration in the compilation sequence: Screenshot 2019-05-07 at 16 25 47

drhumlen avatar May 07 '19 14:05 drhumlen

@varon We've started working on adding Expecto support to Rider. It currently seems nothing needs to be added or changed in Expecto itself to get some initial tests running/debugging.

auduchinok avatar Aug 20 '19 14:08 auduchinok

GLORIOUS

varon avatar Aug 20 '19 14:08 varon

@auduchinok : It may be a lot to ask, but will it also allow us to see coverage? That could be very useful

drhumlen avatar Aug 26 '19 11:08 drhumlen

@drhumlen There're chances it will be able to get it (almost?) for free the same way we didn't have to do anything to get coverage working in F#. If it only requires implementing some simple Expecto-specific components then it'll be easy to address. We'll see. :)

auduchinok avatar Aug 26 '19 11:08 auduchinok

@auduchinok. Cool! :) Do you have any ETA? (I'm using EAPs whenever available)

drhumlen avatar Aug 26 '19 12:08 drhumlen

@drhumlen No estimates to share for now.

If you want some status updates, here're a test session results for the Expecto dotnet template, after run/debug:

Screenshot 2019-08-23 at 15 09 15

Now it needs more work in the discovery part.

auduchinok avatar Aug 26 '19 14:08 auduchinok

Any progress on getting expecto integrated into Rider? Really love both :)

ErikSchierboom avatar Nov 16 '19 13:11 ErikSchierboom

@ErikSchierboom Yes, most of pre-requirements on F# plugin side are ready. We need to finish integration of inner tests discovery and some other things. It's likely it all can come to 2020.1 EAP, though, no particular promises for now, since it also needs changes in Rider itself. :)

auduchinok avatar Dec 02 '19 11:12 auduchinok

Great! Looking forward to it.

ErikSchierboom avatar Dec 03 '19 08:12 ErikSchierboom

I'm suspecting that it's really hard for Rider to pinpoint the location of a test since Expecto by design is all about programmable flexible testing. With the other libraries, modules and their [<Fact>]-let bindings are unambiguously placed, but with expecto it can be anywhere.

If it doesn't make sense to add Expecto support to Riderr, that's ok. There are other more low-hanging fruits I'd rather have I think. 🤔

drhumlen avatar Mar 25 '20 12:03 drhumlen

@fc1943s Sorry for no updates. We didn't move much forward during 2020.1 development cycle. Some of the changes on F# support side depend on a unit test infrastructure refactoring and it was postponed till 2020.2 AFAIK. I'm going to try working it around so in the worst case we could enable at least a limited support in 2020.2 if the unit tests refactoring is not done by that time.

auduchinok avatar Mar 25 '20 12:03 auduchinok

Thanks for the update @auduchinok. Really looking forward to this!

varon avatar Apr 03 '20 12:04 varon

Rider 2020.2 did some huge updates to the way testing is handled. @auduchinok do you know if this allows Expecto to work?

Edit: https://www.jetbrains.com/rider/whatsnew/#unit-testing

varon avatar Aug 13 '20 23:08 varon

@auduchinok bump

varon avatar Aug 22 '20 13:08 varon

@varon Sorry for the delay. Yes, these changes were one of the most important things we've waited for in the plugin.

auduchinok avatar Sep 18 '20 14:09 auduchinok

Is there any update on ETA for this please?

mdpedersen avatar Dec 07 '20 17:12 mdpedersen

Is there any update for this ?

lucasteles avatar Feb 17 '21 22:02 lucasteles

@lucasteles @marlinla @fc1943s @mdpedersen - Would be good if someone could give it a try.

Maybe things work now?

varon avatar Feb 25 '21 12:02 varon

As of 2021.1 EAP9 Beta, there's still no support.

From Resharper release notes:

We’ve implemented support for VSTest adapters – a feature that allows you to discover and run tests from a third-party framework.

Unfortunately, Rider still won't recognise the test project. Note, this is listed in the Resharper release notes, so there may be some work still needed on the Rider side, and I'm jumping the gun.

Looks like we could be close though!

@auduchinok What blockers are remaining on this?

JacksonCribb avatar Mar 26 '21 01:03 JacksonCribb

I just want to bump this - as this is one of the blockers for me atm.

C0DK avatar Sep 25 '22 13:09 C0DK

@C0DK Rider integration works for me with these two packages installed in the test project:

Microsoft.NET.Test.Sdk
YoloDev.Expecto.TestSdk

Did you try that?

nikolamilekic avatar Sep 25 '22 13:09 nikolamilekic

@C0DK also try "Enable VSTest adapters support" image

SimonCropp avatar Sep 25 '22 22:09 SimonCropp

@SimonCropp enabling VSTest adapters worked for me with 2022.2.3

ghost avatar Sep 28 '22 13:09 ghost

@awbv glad u got it working

SimonCropp avatar Sep 28 '22 20:09 SimonCropp

above steps doesn't work for me targeting net7.0 with rider 2022.3 EAP9. I can do dotnet test from the solution dir, but sadly rider is showing me image

anpin avatar Dec 03 '22 09:12 anpin

Same for me with 2023.2 on .NET 7, Linux. I installed both

Microsoft.NET.Test.Sdk
YoloDev.Expecto.TestSdk

and enabled VSTest adapters support, but the discovery finds nothing.

arialdomartini avatar Aug 08 '23 21:08 arialdomartini

I just tried with Windows and both .NET 7 and .NET 6. Enabling VSTest adapters support it works perfectly!

image

arialdomartini avatar Aug 09 '23 05:08 arialdomartini

I have VSTest adapters support enabled and the Expecto.Sample tests are not being discovered in Rider 2023.2 on Windows.

I also tried adding the *Sample* or *Expecto.Sample* mask which did not make a difference.

poroburu avatar Aug 22 '23 00:08 poroburu