Christiano Haesbaert

Results 104 comments of Christiano Haesbaert
trafficstars

Merging is blocked as waiting a review from @fearful-symmetry , is this because we need a reviewer from each team?

> @haesbaert any idea why the filebeat tests are failing, they don't seem to be related to my changes . No idea, I'll ping some people, I don't think it...

Sorry for the absurd delay in answering this. The idea for those binaries were to not be shipped more like a debugging tool while I was developing, especially the test-arp...

> The opam supported options would be either: > > 1. include them as test dependencies and use `with-test` to include any extra libraries that aren't required for the library....

That's great, I'll have a proper review in this and all the other PRs tomorrow, I'll test this during the weekend in my network home to see if nothing breaks...

I agree ! I'm just not sure we can just flip it, hopefully we can. Here is the original source: https://groups.google.com/g/lock-free/c/Vd9xuHrLggE/m/B9-URa3B37MJ?pli=1

I don't have a proper setup to test this yet for regressions, so I didn't build it. Again, I apologize if the changes are too pedantic.

Thanks for reviewing it. I've re-added the braces as requested as well as the Sign-off-by.

I'd like to take up on this, I wrote the cpu topology used in OpenBSD ages ago so hopefully I can contribute something. @dra27 and @kayceesrk expressed interested in this...