Hadley Wickham comments

Results 2585 comments of


                                            Hadley Wickham

map_dfr

Right, because this is one of the edge cases that IMO should never have worked (i.e. it's a bug).

map_dfr

Yeah, I think this would be useful to add to the examples.

Create fr-CA variant?

Since we're currently 50-50 on French Canadians and this term, I think we can try and skip creating a specific variant just for fr-CA.

Path issue in Quarto vignette / article

I think your issue is missing some text?

Invalid "use pkgdown::clean_site()" advice

Hmmm, I think it's the advice that's wrong here — `clean_site()` is specifically for cleaning up sites (as the name suggests 😄) not deleting directories that aren't sites.

Provide advice for testing on CRAN

And recommend that you test with dev httr2 since most tests won't be run on CRAN.

Provide advice for testing on CRAN

Use vcr

`is_dictionarish(NULL)` should return `TRUE`

I don't, but I suspect it was an argument where the default was `NULL` and the expected type was a list.

`dbplyr_uncount()` on Redshift tables fails with an opaque error

Thanks for the detailed analysis and PR. Your explanation and fix makes sense to me, so I'll hopefully get it merged shortly.

default_aes not used in compute_*() methods

If there's an underlying reason I have long since forgotten it. Maybe it's to avoid some sort of precedence clash between stats and geoms?