Hadley Wickham comments

Results 2587 comments of


                                            Hadley Wickham

unhelpful warnings in check_pkgdown

Should fix with `check_string()` or similar.

Comparison for very long lines could be truncated

Somewhat related to #57, but not directly since here you have two very long strings that are completely different.

Could a `str_to_snake` function be made to convert strings to snake-case?

Hmmmm, we'd probably want to add `str_to_camel()` (`strToCamel()`?) for completeness.

Could a `str_to_snake` function be made to convert strings to snake-case?

I think you could just implement it in R, using a regular expression or other stringr functions.

Uninformative comparison of complex with testthat tolerance

It's not just complex numbers: ``` r x

Uninformative comparison of complex with testthat tolerance

And now that I've fixed #141, this problem has gone away 😄

Equivalent environments are seen as different when named

Named environments are deliberately compared by reference as of #133. I made that change as part of https://github.com/r-lib/waldo/issues/127#issuecomment-1063488933 — waldo compares generally compares environments by values but it compare named...

Equivalent environments are seen as different when named

I'm going to close this issue because I think it is out of scope, and it sounds like you have a work around.

Enable starting search with keyboard shortcut

Is this something you'd be interested in doing a PR for?

Enable starting search with keyboard shortcut

This would be a good project for someone who knows a little bit about HTML and JS. Since the pkgdown search is a bit simpler than quarto, I think all...