Hadley Wickham comments

Results 2588 comments of


                                            Hadley Wickham

Installation on R < 4.0 fails on `evaluate` now requiring R >= 4.0

Given that it seems like 3.6 is going to be around for a while, we want to at least reserve the possibility of continuing test some packages on 3.6. That...

Installation on R < 4.0 fails on `evaluate` now requiring R >= 4.0

After more time has elapsed it seems like requiring R 4.0.0 caused few problems (especially once we changed our GitHub action to install older versions if necessary).

Exported functions missing from "Expectation Internals" section of website's reference index

i.e. `expect_success()`

Exported functions missing from "Expectation Internals" section of website's reference index

Looks like this is fixed in the dev version: https://testthat.r-lib.org/dev/reference/index.html#expectation-internals

Not accurate test counting in normal and Rmarkdown runs

I don't really understand what you're asking here. Counting tests isn't an advertised feature of testthat.

Not accurate test counting in normal and Rmarkdown runs

I don't ever use that functionality, so I don't have any insight, sorry.

Proposal: add a custom signal class for skip(), then sort skip notes by class

How about the ability to add a sort key to the skip object? Then we'd just sort by that, and you'd be free to define as you wish.

Proposal: add a custom signal class for skip(), then sort skip notes by class

But if it's not in your control, how would you add the custom class?

Proposal: add a custom signal class for skip(), then sort skip notes by class

Yeah, why don't we rework that skip message since we're doing that anyway 😄

line end with snapshots?

Snapshot files should already be written with consistent line ending, so if you're seeing problems that's definitely a bug.