Hadley Wickham

Results 2589 comments of Hadley Wickham

This is also causing build failures for usethis.

The check looks pretty robust: https://github.com/wch/r-source/blob/be69922efa4e9c01c9169c9ba15557df813168e5/src/library/tools/R/orcidtools.R#L36-L52 So I don't see an obvious to construct an obviously fake ORCID that would still pass the test.

I like the idea of using `rstudioapi::askForPassword()` instead of `readline()` since a modal dialog is harder to miss/ignore. Could also look into [askpass](https://cran.r-project.org/web/packages/askpass/index.html) which does a similar thing in a...

Having a `snapshot_reject()` does seem reasonable.

This feels a bit too special purpose for usethis to me, given that it's not hard to add it manually or with desc.

Hmmm, it looks like I totally removed data frame support in #895 and then partially bought back support in 2ad46d508d46b5630fbe5bcd89e532538f11ab79. I can't remember exactly why, but this problem of matching...

I think it's telling that https://github.com/search?q=path%3Aimport-standalone-cli.R&type=code doesn't include any tidyverse or r-lib packages. Are we sure that this file is part of a workflow that we still recommend?

@lionel- it's not something we'd recommend that other people use, right?

I feel like we should be very cautious about automating our standalone file approach too much. I'm worried people are going to gravitate towards when in most cases they would...