Hadley Wickham

Results 2594 comments of Hadley Wickham

It also breaks rmarkdown 😬 ``` Error in `if (grepl("^[.][.]", in_file)) ...`: ! the condition has length > 1 --- Backtrace: ▆ 1. └─pkgdown::build_article("from-base", new_process = FALSE) 2. └─pkgdown:::render_rmarkdown(...) at...

rmarkdown patch in https://github.com/rstudio/rmarkdown/pull/2416. Breaking rmarkdown is a big deal, so I don't think we should merge this until after rmarkdown is released, so it probably won't make it for...

Yeah, the failures seem to be cases that expected a single string. So there's always a trivial fix, which is to vectorise with `vapply()` or similar. When I do the...

Fixed in rmarkdown 2.17, but I think this will have to wait until the next release since otherwise installing stringr will break older (i.e. most) rmarkdown installed.

I think enough time has elapsed that we can now merge this, fixing the 7 CRAN failures with PRs.

Yeah, this is the approach that I'd recommend since the regexp engine can efficiently compile. If you're accepting user provided strings, make sure to call `str_escape()` to escape any special...

I think the easiest fix would be to simply revert to the previous behaviour.

@peterdesmet I don't think so, because the R object that is best equivalent to SQL's `NULL` is `NA`: ``` r library(glue) con SELECT NULL AS rights_holder, * FROM data ```...

And improve the documentation for the `.envir` argument.