hadashiA
Fix duplicate injection issue + introduce Editor tests
Addressing issue #669:
Currently if TypeAnalyzer encounters duplicate field (with the same Name) in a base class, it skips injection for this class. As a result all the following fields of a base class are not injected. It leads to unexpected runtime behaviour. There are two solutions:
- supporting "duplicate injections" like Zenject does
- throwing exception to give immediate feedback that Injection process will go wrong
I did the 2nd approach as it detects developer's mistakes that in most cases can be easily fixed by protected injections.
Ps. I've also introduced the Editor tests. Is there any reason why most tests have to be run in a Playmode? If you like I can tweak & merge my test with others related to the TypeAnalyzer. Just wanted to know the approach :)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| vcontainer | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 4, 2024 7:06am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for the PR 🙏
Ps. I've also introduced the Editor tests. Is there any reason why most tests have to be run in a Playmode? If you like I can tweak & merge my test with others related to the TypeAnalyzer. Just wanted to know the approach :)
Indeed, most may not need to be in Play mode. However, there are tests in Play mode, so I preferred to have one test assembly rather than multiple separate ones.
Maybe we could split them up as you suggest.
However, in this PR, the .UnitTests asmdef has been added, but in fact the current .Tests is also a Unit Test, so maybe the name is a bit inappropriate?
If there are no strong opinions I think we could leave it as just Play mode, but what do you think?
I think we could rename VContainer.Tests to VContainer.PlayModeTests and VContainer.UnitTests to VContainer.EditModeTests. However moving DuplicateInjectionTest to VContainer.Tests is also fine for me. I can also move it to TypeAnalyzerTest if you think my fix is ok and don't want to rework the flow in that regard.
I can also move it to TypeAnalyzerTest if you think my fix is ok and don't want to rework the flow in that regard.
I would like to treat the renaming of asmdef as a separate matter, so I would appreciate it if this PR did this.