hax icon indicating copy to clipboard operation
hax copied to clipboard

Frontend: THIR: missing `impl_expr` on `GlobalName`

Open W95Psp opened this issue 1 year ago • 5 comments

The node GlobalName doesn't carry a impl_expr field, but Rust allow to do e.g. f(Trait::method).

I wonder if we should not move impl_expr and other similar fields from the constructor Call to the constructor GlobalName. That would make more sense.

W95Psp avatar Oct 14 '24 06:10 W95Psp

Do you mean ExprKind::GlobalName? You're also missing generic_args then.

Nadrieril avatar Oct 14 '24 08:10 Nadrieril

Yes, that's what I had in mind as "similar fields" ^^

W95Psp avatar Oct 14 '24 09:10 W95Psp

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Dec 17 '24 02:12 github-actions[bot]

This issue has been closed due to a lack of activity since being marked as stale. If you believe this issue is still relevant, please reopen it with an update or comment.

github-actions[bot] avatar Dec 26 '24 01:12 github-actions[bot]

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar May 08 '25 00:05 github-actions[bot]

Still needed.

karthikbhargavan avatar Jun 05 '25 11:06 karthikbhargavan