hax icon indicating copy to clipboard operation
hax copied to clipboard

Support `PartialOrd` and other generated things

Open W95Psp opened this issue 1 year ago • 7 comments

For a bunch of "standard" derived core traits, we just ignore generated code.

  • PartialOrd, Ord: straightforward, we might want lemmas saying that if x <= y and x >= y, then x == y, but this might not always be true (note: Ord vs PartialOrd, and is == Rust equality or theorem prover equality?)
  • PartialEq, Eq: more complicated. It's perfectly fine to implement Eq and PartialEq to reflect equality on a partial view of a value.
  • Debug: should be fairly easy
  • Copy: implement as identity, it's only a marker-trait
  • Clone: I think we still want to model clones as copies. A clone that is doing something more than cloning sub-values usually means it's doing a side effect (e.g. Rc).

W95Psp avatar Aug 12 '24 13:08 W95Psp

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Oct 12 '24 02:10 github-actions[bot]

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Dec 14 '24 02:12 github-actions[bot]

Still relevant, we discussed that recently with @maximebuyse

W95Psp avatar Dec 16 '24 07:12 W95Psp

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar May 22 '25 00:05 github-actions[bot]

@maximebuyse can you look at it?

W95Psp avatar Jul 10 '25 13:07 W95Psp

I looked at the current behaviour, and I don't think anything changed since this issue was opened. We make derived trait impls opaque. So this issue is still fully relevant.

maximebuyse avatar Jul 17 '25 08:07 maximebuyse

Will probably be addressed when porting the importer to rust

clementblaudeau avatar Nov 13 '25 12:11 clementblaudeau