hax icon indicating copy to clipboard operation
hax copied to clipboard

Engine: Error reporting with `NotImplementedYet` items

Open paulmure opened this issue 1 year ago • 9 comments

The AST definition of the engine has a constructor named NotImplementedYet which is emitted by the importer when encountering things like external crates, inline assembly, unions etc.

There's currently no error reporting when such an item is encountered. Furthermore, when an engine receives this AST item, the information about what the original item was is already lost.

One annoying example is the fact that every crate seems to have extern std automatically inserted by the compiler, which should be safe to ignore by most backends but we can't tell if that is what got passed down.

Can we maybe add AST definitions for these items in the engine and feature gate them? Or at least give some better error messages to users.

paulmure avatar Jul 15 '24 22:07 paulmure

Hi, as we discussed on Zulip yesterday, I think getting rid of this NonImplementedYet variant would be great! If you need any pointers or help for adding those, tell us :)

Btw, if representing every missing items is a too long process, one way forward would be to add a few of them, and then rename NotImplementedYet into UninterpretedThir, a variant that would hold a Type.impl_item_kind_for__decorated_for__expr_kind.

W95Psp avatar Jul 18 '24 08:07 W95Psp

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Sep 17 '24 01:09 github-actions[bot]

This issue has been closed due to a lack of activity since being marked as stale. If you believe this issue is still relevant, please reopen it with an update or comment.

github-actions[bot] avatar Sep 24 '24 02:09 github-actions[bot]

That was still relevant, the bot was too quick

W95Psp avatar Sep 30 '24 06:09 W95Psp

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar Nov 30 '24 02:11 github-actions[bot]

This issue has been closed due to a lack of activity since being marked as stale. If you believe this issue is still relevant, please reopen it with an update or comment.

github-actions[bot] avatar Dec 08 '24 02:12 github-actions[bot]

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar May 22 '25 00:05 github-actions[bot]

Still relevant

W95Psp avatar Jul 10 '25 09:07 W95Psp