hacspec
Cleanup dependencies and license checks
After adding license checks in #1035 I reviewed them in #1088. This issue capture the resulting action items. The licenses themselves are ok. But the checking isn't quite right and there's a dependency that needs to go.
Remove depdencies
Drop proc-macro-error. It is unmaintained. There's an alternative crate (proc-macro-error2) that may be an alternative if needed.
Script does not work
The script to check licenses doesn't work (at least on macos). grep: invalid option -- P.
The resulting bigger problem is that it still print "ok" even when it didn't do anything.
This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been closed due to a lack of activity since being marked as stale. If you believe this issue is still relevant, please reopen it with an update or comment.
This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.
The dependency proc-macro-error is gone since #1385, so that part is fixed.
This is still relevant otherwise:
- [ ] fixing the script for MacOS
- [ ] improve the check, @franziskuskiefer what did you mean by "isn't quite right"?
If I recall correctly the check is only looking for a license, not if this must be combined with a different one (like there are A+B licenses where both must be adhered to). But I may be wrong. I can try to take a look again later.