integration icon indicating copy to clipboard operation
integration copied to clipboard
verified publisher icon hacs

Remove netdaemon support

Open emontnemery opened this issue 1 year ago • 4 comments

Remove deprecated netdaemon support

emontnemery avatar Apr 09 '24 06:04 emontnemery

~~HacsConfiguration.update_from_dict needs to be adjusted to ignore saved netdaemon configuration~~

Edit: Fixed + test added

emontnemery avatar Apr 09 '24 06:04 emontnemery

@coderabbitai review

emontnemery avatar May 24 '24 09:05 emontnemery

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot] avatar May 24 '24 09:05 coderabbitai[bot]

Walkthrough

Walkthrough

The updates focus on the removal of netdaemon related configurations and test cases. This includes deleting specific tests checking netdaemon features, altering JSON configuration files to exclude netdaemon options, and refining the code format for better readability. Collectively, these changes streamline the codebase by discarding obsolete or unnecessary components linked to netdaemon.

Changes

Files Change Summary
tests/hacsbase/…/test_backup.py, tests/helpers/download/…/test_… Removed test_netdaemon_backup and test_gather_netdaemon_files_base.
tests/snapshots/diagnostics/… Removed netdaemon options and settings from JSON configuration files.
tests/test_config_flow.py Reformatted code for improved structure and readability.
tests/utils/test_validate.py Removed "netdaemon" string from the list tested in test_critical_repo_data_json_schema_bad_data.

Sequence Diagram(s)

No sequence diagrams are needed as the changes are focused on code cleanup and reformatting without introducing new features or altering existing control flow mechanisms.

Recent review details

Configuration used: CodeRabbit UI Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 7d41e233737a12b426ea8f47beba0587ae7ad064 and 86fbe60fdbf28d0124c87e202fc24eccb9ba62db.

Files selected for processing (21)
  • action/action.py (1 hunks)
  • custom_components/hacs/base.py (3 hunks)
  • custom_components/hacs/config_flow.py (2 hunks)
  • custom_components/hacs/diagnostics.py (1 hunks)
  • custom_components/hacs/enums.py (1 hunks)
  • custom_components/hacs/repositories/init.py (2 hunks)
  • custom_components/hacs/repositories/base.py (4 hunks)
  • custom_components/hacs/translations/en.json (1 hunks)
  • custom_components/hacs/utils/backup.py (1 hunks)
  • custom_components/hacs/utils/configuration_schema.py (1 hunks)
  • custom_components/hacs/utils/path.py (2 hunks)
  • custom_components/hacs/utils/validate.py (1 hunks)
  • tests/conftest.py (3 hunks)
  • tests/hacsbase/test_backup.py (2 hunks)
  • tests/hacsbase/test_configuration.py (2 hunks)
  • tests/helpers/download/test_gather_files_to_download.py (1 hunks)
  • tests/output/proxy_calls.json (2 hunks)
  • tests/snapshots/diagnostics/base.json (2 hunks)
  • tests/snapshots/diagnostics/exception.json (2 hunks)
  • tests/test_config_flow.py (10 hunks)
  • tests/utils/test_validate.py (1 hunks)
Additional context used
Path-based instructions (3)
tests/snapshots/diagnostics/exception.json (1)

Pattern tests/**/*.json: Never suggest changes to the JSON files located under the tests directory

tests/snapshots/diagnostics/base.json (1)

Pattern tests/**/*.json: Never suggest changes to the JSON files located under the tests directory

tests/output/proxy_calls.json (1)

Pattern tests/**/*.json: Never suggest changes to the JSON files located under the tests directory

Additional comments not posted (17)
tests/hacsbase/test_backup.py (1)

5-5: Import statement is correct.

The import statement for Backup is necessary for the test cases.

tests/hacsbase/test_configuration.py (1)

49-55: LGTM!

The new test function test_ignore_netdaemon correctly verifies that the netdaemon setting is ignored.

tests/snapshots/diagnostics/exception.json (1)

10-10: Approved: Removed netdaemon option.

The removal of the netdaemon option is consistent with the PR objectives to remove deprecated support.

custom_components/hacs/utils/backup.py (1)

Line range hint 1-70: No changes detected.

This file has no changes related to the removal of netdaemon support.

tests/snapshots/diagnostics/base.json (1)

10-10: Approved: Removed netdaemon option.

The removal of the netdaemon option is consistent with the PR objectives to remove deprecated support.

action/action.py (1)

Line range hint 1-111: No changes detected.

This file has no changes related to the removal of netdaemon support.

tests/helpers/download/test_gather_files_to_download.py (1)

Line range hint 1-1: Confirm removal of test_gather_netdaemon_files_base.

The test function test_gather_netdaemon_files_base has been removed, aligning with the objective of removing netdaemon support.

tests/test_config_flow.py (6)

70-71: Confirm formatting improvements.

The formatting improvements enhance code readability without changing functionality.

149-150: Confirm formatting improvements.

The formatting improvements enhance code readability without changing functionality.

197-198: Confirm formatting improvements.

The formatting improvements enhance code readability without changing functionality.

267-268: Confirm formatting improvements.

The formatting improvements enhance code readability without changing functionality.

300-301: Confirm formatting improvements.

The formatting improvements enhance code readability without changing functionality.

324-325: Confirm formatting improvements.

The formatting improvements enhance code readability without changing functionality.

tests/conftest.py (1)

Line range hint 1-200: No changes detected.

This file does not contain any marked changes.

tests/utils/test_validate.py (1)

Line range hint 1-200: LGTM! "netdaemon" removal confirmed.

The removal of the "netdaemon" string from the test data is consistent with the PR objective to remove deprecated netdaemon support. The rest of the test function remains logical and functional.

custom_components/hacs/base.py (1)

143-145: LGTM! "netdaemon" removal confirmed.

The removal of the "netdaemon" key from the update_from_dict method is consistent with the PR objective to remove deprecated netdaemon support. The rest of the method remains logical and functional.

tests/output/proxy_calls.json (1)

Line range hint 1-1: JSON Structure Validation

The JSON structure appears to be correctly formatted and valid. No issues found.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 24 '24 09:05 coderabbitai[bot]

@coderabbitai full review

ludeeus avatar Jul 05 '24 11:07 ludeeus