HackyMiner

@sammy007 // hello~ thanks for your great project! if you have any interest or some free time to review this code, please let me know or I will make a...

@aemet93 // sorry for late answer. it works nicely with my local pool setup. what is your setup or any error log?

Hi! extranonce (`randomHex(4)`) + nonce(`12 len` hex string) makes total `16` bytes len. (extranonce) https://github.com/sammy007/open-ethereum-pool/pull/417/commits/185febe9bf100124231f25095fd5979d08e1cb60#diff-40ea75f4bd2f5f500a0cc37a432246faR551 (nonce = extranonce + `param[2]`(miner nonce from miner)) https://github.com/sammy007/open-ethereum-pool/pull/417/commits/185febe9bf100124231f25095fd5979d08e1cb60#diff-40ea75f4bd2f5f500a0cc37a432246faR265 I guess the extranonce was missing...

> > Hi! > > Hi, thanks for the reply! > > > I guess the extranonce was missing or not properly prepended at pool side. > > I've dumped...

> Thanks, @hackmod. > > As I see from the code > > ``` > // check Extranonce subscription. > extranonce := cs.Extranonce > if !cs.ExtranonceSub { extranonce = ""...

this is the original unified nicehash-v1 branch https://github.com/EthersocialNetwork/open-ethereum-pool/tree/unified-nicehash-v1-original I guess, lost shares may be caused by the following code. (original NH fix always drop these shares) https://github.com/EthersocialNetwork/open-ethereum-pool/commit/254d409596132a3546ebfa3823c885ea908066fa

parity is recommended by maintainer but the latest geth v1.8.17 also work - geth above v1.8.17 (extended `eth_getWork`) for ethereum. - recent stable parity

why don't you rebase instead of revert or merge?

i guess you've missed `--mine` option, like as `geth --mine ....` See also https://github.com/ethereum/go-ethereum/issues/17693

See also https://github.com/ethereum/go-ethereum/pull/18038 geth 1.8.18 will support `getWork` fourth parameter.