codimd icon indicating copy to clipboard operation
codimd copied to clipboard

Support permission of invitee only

Open jackycute opened this issue 10 years ago • 18 comments
trafficstars

Should support a permission of invitee only. Only the invitee from email or link can edit the note.

jackycute avatar Oct 02 '15 17:10 jackycute

We supported private permission in 49c7dded4539044d8053dba8d3fe24b97056c0d2. private means only owner can view and edit.

jackycute avatar Mar 24 '16 14:03 jackycute

We supported limied and protected permissions in a8068d38d589a1b8ed008f737d42ed35df4bfd2b. limited is similar to editable but forbid guest to view. protected is similar to locked but forbid guest to view.

jackycute avatar Jan 16 '17 16:01 jackycute

This list is quite long by now. While I find all the items' names to be very carefully chosen, yet I still have to look up which is which. While permissions are being extended, maybe it's a good idea to revisit how a user sets these permissions. Maybe it's not one long list from "very private" to "very public" but two sliders, one for reading and one for writing. Or something else entirely.

ccoenen avatar Mar 13 '17 09:03 ccoenen

@ccoenen So actually we only need to choose one of read or write permission for every invited user. Not one from current permission types.

jackycute avatar Mar 13 '17 09:03 jackycute

I'm not quite understand your permission system. If I set limited, does it mean that everyone who is registered on the site can view/edit it? How can I allow access only to the list of certain persons?

Himura2la avatar Mar 29 '17 16:03 Himura2la

We currently have six permissions, I would suggest to read it here: https://hackmd.io/features#permissions

There is no way to allow only for certain people to access note for now. So this is the issue open for it, and this invitee will be the seventh permission.

jackycute avatar Mar 29 '17 18:03 jackycute

Thanks, looking forward for having this feature implemented.

Himura2la avatar Mar 29 '17 18:03 Himura2la

Let me add a little bump to this issue. Sadly this missing feature forced me to drop this tool in favor of something else.

Keeo avatar Sep 13 '17 15:09 Keeo

@Keeo Out of curiosity: what alternative are you using?

ccoenen avatar Sep 13 '17 19:09 ccoenen

@ccoenen We downloaded markdown file from hackmd and placed it inside github repository. Collaboration is done thought normal github process and just for rendering use hackmd.

Keeo avatar Sep 15 '17 14:09 Keeo

One of the best editors out there, yet one of the worst permission systems. How is this even reasonable to let anyone signed in to edit your notes?

illyas3 avatar Apr 10 '18 10:04 illyas3

You can change the permission to freely, when you don't want everyone to sign in.

The permission system is mainly grown over time. It definitely needs re-factoring but that also needs time :) If you want to spend some time on the project and work on the permission system, that's definitely an appreciated work.

So feel free to file a PR :)

If you have question or want to talk about concepts feel free to join the Matrix and Gitter community and talk with us.

SISheogorath avatar Apr 10 '18 10:04 SISheogorath

It would certainly rock to have something like "this list of people is allowed" or "these five people form a group, that group owns this document" or "i can edit, only that group can read"

but somebody has to write that, and currently even something as basic as user accounts is, let's say, very rudimentary. To be honest, I wouldn't expect this any time soon unless somebody picks it up as a pull request.

ccoenen avatar Apr 10 '18 21:04 ccoenen

Why not an invite-only link with read and/or write permissions, like it is conventional in many other web tools (e.g. nextcloud)? It is so, that very often there is the need to share documents to review with external people who won't additionally create an account.

They could via such a link just jump in to the document and start editing. And this wouldn't really require an additional permission in the list (I also find they start getting very confusing, as someone commented above), just an option to share a link, e.g. via a button next to Publish. As such, this invite link would work independently from the specific permission settings for the document.

gandhiano avatar Apr 26 '18 09:04 gandhiano

I think that the password feature (#494) could be a workaround for most use cases mentioned here, without making the permission system more complicated.

jaragunde avatar Apr 26 '18 09:04 jaragunde

any update on this issue?

It would be superb to have a sharing feature like Google Docs and showing them only to invitees.

RyoMurakami582 avatar Sep 17 '18 06:09 RyoMurakami582

No, no changes on that, yet. https://demo.codimd.org/features#Permissions

But we welcome contributions! If you want to help or just talk a bit about it, feel free to join us in our Matrix community: #codimd:matrix.org

SISheogorath avatar Sep 17 '18 07:09 SISheogorath

Hi All, This feature would be very nice to have. Would it be possible to bump this up in priority?

abhijitm08 avatar Jan 13 '25 15:01 abhijitm08