codimd
codimd copied to clipboard
CSS style unreadable for Mermaid dark mode
Looks fine in light mode, text unreadable in dark mode.
Thanks for firing up this issue. After some investigations, I found that it consists of 2 issues:
- The mermaid stylesheet is outdated. Mermaid now embed styles inline when generating svg. This stylesheet should be removed (from our webpack config).
- Night mode implementation for mermaid is also outdated. Latest mermaid provides 4 different themes. We should feed in mermaid theme option based on current theme, and then trigger a rerender. https://github.com/hackmdio/codimd/blob/558fa5fcf46b0a94c49c503c2e1373c86829ff1e/public/js/extra.js#L397
Ref: https://stackoverflow.com/questions/49535327/change-mermaid-theme-in-markdown
@Yukaii I want to work on this issue
Hey, @Yukaii I would like to work on this. can you please assign it to me?
Hey, @Yukaii I would like to work on this. can you please assign it to me?
I want to work on this issue, please assign me.
Hey @Yukaii , could I work on this issue?
Yoi ! @Yukaii is this issue still open ?
Why is nobody being assigned to this issue?