codimd icon indicating copy to clipboard operation
codimd copied to clipboard

CSS style unreadable for Mermaid dark mode

Open 917huB opened this issue 5 years ago • 8 comments

Looks fine in light mode, text unreadable in dark mode. UML-dark UML-light

917huB avatar Nov 10 '19 09:11 917huB

Thanks for firing up this issue. After some investigations, I found that it consists of 2 issues:

  1. The mermaid stylesheet is outdated. Mermaid now embed styles inline when generating svg. This stylesheet should be removed (from our webpack config).
  2. Night mode implementation for mermaid is also outdated. Latest mermaid provides 4 different themes. We should feed in mermaid theme option based on current theme, and then trigger a rerender. https://github.com/hackmdio/codimd/blob/558fa5fcf46b0a94c49c503c2e1373c86829ff1e/public/js/extra.js#L397

Ref: https://stackoverflow.com/questions/49535327/change-mermaid-theme-in-markdown

Yukaii avatar Nov 12 '19 05:11 Yukaii

@Yukaii I want to work on this issue

RamGoel avatar Jul 15 '22 07:07 RamGoel

Hey, @Yukaii I would like to work on this. can you please assign it to me?

sajdakabir avatar Jan 18 '23 13:01 sajdakabir

Hey, @Yukaii I would like to work on this. can you please assign it to me?

classr-22 avatar Feb 12 '23 11:02 classr-22

I want to work on this issue, please assign me.

abhishek-kumar-91 avatar Mar 21 '23 15:03 abhishek-kumar-91

Hey @Yukaii , could I work on this issue?

siddarthpai avatar Jun 08 '23 15:06 siddarthpai

Yoi ! @Yukaii is this issue still open ?

Groot-2001 avatar Aug 18 '23 04:08 Groot-2001

Why is nobody being assigned to this issue?

ancxanas avatar Oct 30 '23 21:10 ancxanas