hackerAPI icon indicating copy to clipboard operation
hackerAPI copied to clipboard

Make parsePatch method generic

Open pierreTklein opened this issue 7 years ago • 6 comments

Can we extract this into a general service method that takes original object and a schema, and returns the attributes that match the schema?

Originally posted by @pierreTklein in https://github.com/hackmcgill/hackerAPI/pull/277

pierreTklein avatar Jan 08 '19 22:01 pierreTklein

Drop some roast :fire: if there's an issue! Sorry for the delay, been busy with work on boarding but more should roll out slowly :') :+1: If its all good, I'll start making use of the service to replace the manual parsePatch Functions across the middleware

Ty-Won avatar Jun 21 '19 05:06 Ty-Won

Is there a PR for this?

pierreTklein avatar Aug 07 '19 20:08 pierreTklein

No I wasnt sure if I should have created a PR since the method needs to be called across different services and I just started with the implementation of the method to see if it was alright before putting it across the api

Ty-Won avatar Aug 07 '19 21:08 Ty-Won

*across different middleware

Ty-Won avatar Aug 07 '19 21:08 Ty-Won

Maybe a draft PR is the best way? https://github.blog/2019-02-14-introducing-draft-pull-requests/

krubenok avatar Aug 07 '19 21:08 krubenok

Yeah sure that's true!

Ty-Won avatar Aug 09 '19 01:08 Ty-Won