Karthic Rao

Results 24 comments of Karthic Rao

@generall : The issue happens only when I block the async upsert operation function using `use futures::executor::block_on`. This is leading to a deadlock down the line while upserting data. I...

Hey @cpcloud , I've addressed most of your comments apart from the tests and documentation. Please let me know if these changes look good. I'll be working on writing the...

@AeonSw4n @lazynina : I made the changes as per your suggestions, thank you for the great inputs and the timely reviews. Here's the summary of my changes. > I find...

Thanks @AeonSw4n . Just that this PR will enable me to do tons of contributions. I'm sweeping through the codebase writing tests, but I can't move forward till this is...

Thanks @AeonSw4n . Getting this merged will also help me fix tests for the #412 PR. Eager to check out the transaction test framework. (On a different note, so cool...

> Just reviewed your latest code, and I've got some minor change requests, but giving you an approve because your code is really awesome! One more comment I have is,...

@AeonSw4n Found the transaction test framework inside the `block_view_test.go`. Working on some refactoring on the suite to improve its usability, for instance, to try parallel transaction scenarios with multiple accounts...

@AeonSw4n Discord is fine, I just need to map the Github accounts to the Discord user names! I'll look into #422 and look into opportunities to contribute.

@lazynina The PR is ready as per the suggestions, do let me know if there's anything more needs to be done for this to be merged :)

Thank you @lazynina . Please do report the edge scenarios when you have them.