Change behavior of "Schedule Friday" workflow for Skills Issues
Dependency
- Wait for PR < > to be merged.
- After the above is merged, move this issue to "New issue approval" and add
Ready for Prioritizationlabel.
Overview
We need to update the "Schedule Friday" workflow so the bot considers all of a member's activity when deciding whether to leave an activity reminder on their Skills Issue.
Details
The bot currently labels members as inactive if they haven't updated their Skills Issue in 7-14 days, even when they're active elsewhere. We need to change the bot to check member activity before it applies inactive labels so that active members don't get incorrectly marked as inactive.
Action Items
- [ ] Check whether a user's Skills Issue has a recent comment. If it doesn't, check whether the bot updated the 'Activity Log' comment on the user's Skills Issue within the last week or last two weeks.
- [ ] Update the code so it checks member activity (not just their Skills Issue) before adding inactive labels.
- [ ] Update the code so the bot applies a new comment to the Skills Issue when the dev has no activity elsewhere.
- [ ] Propose a new bot comment and review it with the team.
Resources/Instructions
- GitHub GraphQL Explorer
- GitHub GraphQL API
- Refer to https://github.com/hackforla/website/issues/6537#issuecomment-2041147335, especially Tips 6, 7, and 8, if you have not already created you personal environment for testing.
- How to Test GitHub Actions
- Additional Notes for GitHub Actions
.github/workflows/schedule-friday-0700.yml(Review how the workflow runs in the Actions tab.)github-actions/trigger-schedule/add-update-label-weekly/add-label.js- files referred to in
add-label.js(like helper files in theutilsfolder)
Hi @kdaca19xx, we notice that you are assigned to an issue that you authored. Please remember to add the Draft label to this issue while you are working on it.
Hi @kdaca19xx Thanks for working on this! Here are some suggested revisions to get started:
- You can remove "ER: " from the title (the ER is the parent issue #8284).
- On #8284, you can select "Create sub-issue" and then "Add an existing issue" (this one) to link them up
- For the reason following, I would move the text from "Overview" into a new section below "### Details"
- The "Overview" should be in the form of "We need to do X for Y reason". From that perspective, the "Overview" could be something similar to what you have in the "Action Items", maybe something along the lines of "We need to update the "Schedule Friday" workflow so the bot considers all of a member's activity when deciding whether to leave an activity reminder on their Skills Issue."
- Instead of referencing all of a member's GitHub activity or GitHub issues, it would be better I think to just say "member activity"
I will add more to this, but in the meantime I think what I mentioned on 8284 is promising for the "Action Items", i.e. to check whether the Skills Issue has a recent comment, and if not "check whether the bot updated the 'Activity Log' comment on the user's Skills Issue within the last week (or last two weeks)", plus the need for "a new comment to be applied to the Skills Issue when the dev has no activity elsewhere"
Thanks again!
Hi @t-will-gillis,
I think I've made all the changes you suggested above. Please confirm and let me know what other edits I should make. Thx in advance!
Hey @kdaca19xx!
- I added a note for the Dependency, and bumped the size up to 5 pt.
- Closing the ER #8284
Thanks for working on this issue!