website icon indicating copy to clipboard operation
website copied to clipboard

Pin projects filter to top of projects list mobile view

Open Maarimar opened this issue 6 months ago • 2 comments

Fixes #7525

What changes did you make?

  • Pinned Filter and Search Bars: The filter and search input fields are now pinned to the top of the screen when scrolling, ensuring they're always accessible for quick adjustments.
  • Filter Counter and Clear All: A new counter has been added to indicate the number of active filters, alongside a convenient "Clear All" option to quickly remove all applied filters.
  • Contextual Filter Pills: Filter "pills" are now displayed only within the opened filter feature, reducing clutter and providing a cleaner interface when filters aren't actively being managed.

Why did you make the changes?

  • To reduce clutter and provide a cleaner interface when filters aren't actively being managed.
  • Improve the usability of filter and have the opportunity to modify search when scrolling projects list.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • [x] I have checked this PR for CodeQL alerts and none were found.
  • [ ] I found CodeQL alert(s), and (select one):
    • [ ] I have resolved the CodeQL alert(s) as noted
    • [ ] I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • [ ] I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website:

Visuals before changes are applied Screenshot 2025-06-18 at 5 31 44 PM Screenshot 2025-06-18 at 5 32 16 PM Screenshot 2025-06-18 at 5 31 03 PM Screenshot 2025-06-18 at 5 31 28 PM Screenshot 2025-06-18 at 5 32 37 PM
Visuals after changes are applied Screenshot 2025-06-18 at 5 33 50 PM Screenshot 2025-06-18 at 5 34 28 PM Screenshot 2025-06-18 at 5 34 47 PM

Maarimar avatar Jun 18 '25 22:06 Maarimar

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Maarimar-Pin-Projects-Filter-to-Top-of-Projects-List-MobileView-#7525 gh-pages
git pull https://github.com/Maarimar/website-HfLA.git Pin-Projects-Filter-to-Top-of-Projects-List-MobileView-#7525

github-actions[bot] avatar Jun 18 '25 22:06 github-actions[bot]

Hi @Maarimar Please do not assign reviewers to your issue, unless either you have spoken with them already or they previously reviewed the same PR and need to re-review it.

In this case, one of the reviewers that you assigned is no longer active in the org. When other, available reviewers see that you have reviewers assigned already, they will likely skip over your PR and you may not have anyone reviewing your PR.

I will un-assign the reviewers.

t-will-gillis avatar Jun 22 '25 16:06 t-will-gillis

ETA: EOD Availability: Sun - Thurs: 6 PM - 8 PM | Fri: 4 PM - 6 PM

dvernon5 avatar Aug 21 '25 01:08 dvernon5

Thank you @dvernon5 for your feedback. I'll work on this this weekend and hopefully we can merge it soon.

Maarimar avatar Aug 21 '25 18:08 Maarimar

@Maarimar can you please give us a status update on this PR? Are you able to make the changes requested or do you need additional help? Thanks!

daras-cu avatar Sep 14 '25 19:09 daras-cu

@daras-cu I have been working on this but haven't been able to fix it. The challenge is that the search bar is nested inside the filter container in the HTML structure, which was necessary for the mobile functionality. We need a solution that visually positions the search bar outside its container on desktop without breaking the mobile behavior. If you have any input I'd appreciate it.

Maarimar avatar Sep 19 '25 19:09 Maarimar

@Maarimar got it, I'll look into it and see if there's an alternate way to place the search bar. @dvernon5 can you also take a look since you are already familiar with this issue?

daras-cu avatar Sep 23 '25 01:09 daras-cu

Hi @Maarimar, I did some research and I think the simplest way to handle the search bar placement issue is to have two search bar elements and use CSS to toggle the display attribute depending on the screen size. You'll have to make some adjustments as the search bar currently uses an id in a couple places, so you'll likely have to use a class instead or create two unique ids to differentiate. It looks like the projects page is currently the only page using a search bar, so the changes you make will not break any other pages, but double check to be sure.

Let me know if that makes sense and if you have any questions. @dvernon5 if you have any input or can think of a better solution let us know as well.

daras-cu avatar Oct 02 '25 03:10 daras-cu

Hi @Maarimar ! Just checking in about the status of this PR. Is everything clear, or do you need anything clarified? Thank you!

DDVVPP avatar Oct 10 '25 23:10 DDVVPP

Hi! @daras-cu Thank you so much for your feedback and ideas. I' think that should solve our problem, it makes a lot of sense to me. Also sorry about my late reply, I've been out for the past few weeks but I an aiming to have this ready for review by the end of the week. @DDVVPP

Maarimar avatar Oct 16 '25 03:10 Maarimar

@Maarimar no worries, glad you are back! I know you've done a lot of work and troubleshooting already on this, thanks for continuing to work on it.

daras-cu avatar Oct 22 '25 01:10 daras-cu

Thanks @Maarimar! Let us know if you need any additional help

DDVVPP avatar Oct 24 '25 19:10 DDVVPP

Apologies for the messy commit history — my local branch got out of sync with the upstream, which caused some duplicate commits to appear here. The relevant changes for this PR are in commit fe7ae6e. Please focus on that one. Sorry again! @dvernon5

Maarimar avatar Oct 28 '25 15:10 Maarimar

Happy to contribute!! @daras-cu @dvernon5

Maarimar avatar Nov 10 '25 19:11 Maarimar