website
website copied to clipboard
Add GitHub handle Ryan Mayott
Fixes #6732
What changes did you make?
- Under "- name: Ryan Mayott" I added "github-handle:"
Why did you make the changes (we will use this info to test)?
- To create a single variable
github-handle
to hold the github handle for Ryan Mayott
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b santisecco-add-github-handle-6732 gh-pages
git pull https://github.com/santisecco/website.git add-github-handle-6732
Review ETA: EOD Availability: 1pm - 4pm 5/14/24
Blocker: it seems like there is a merge happening in the commit history from the gh-pages
branch. This stood out to me as odd. Is it okay to have this?
Hi @urvishp13, the merge from gh-pages
seemed to be the result of incorporating changes from upstream, there's no additional file changes from that merge as seen in https://github.com/hackforla/website/pull/6852/files
The merge commit should not be an issue for approval.
The merge team likely will squash merge this PR so that merge commit won't show up in gh-pages
branch commit history.
Hope this helps.
Okay thanks @tony1ee
Review ETA: 15 May 2024 Availability: weekdays, 2pm – 8pm Pacific Time