website icon indicating copy to clipboard operation
website copied to clipboard

Secured `wins.js` from XSS vulnerability by replacing `innerHTML`

Open danvgar opened this issue 11 months ago • 1 comments

Fixes #6303

What changes did you make?

  • Updated 10 instances of .innerHTML() to use .textContent().

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website

  • No visual changes to report.

danvgar avatar Mar 14 '24 06:03 danvgar

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b danvgar-secure-winsjs-from-XSS-6303 gh-pages
git pull https://github.com/danvgar/website.git secure-winsjs-from-XSS-6303

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/danvgar/website/blob/secure-winsjs-from-XSS-6303/CONTRIBUTING.md  

github-actions[bot] avatar Mar 14 '24 06:03 github-actions[bot]

ETA: 48 hours

ajb176 avatar Mar 15 '24 13:03 ajb176

Review ETA: 3/16/24 Availability: 3/16/24

irais-valenzuela avatar Mar 15 '24 23:03 irais-valenzuela

@Anahisv23 I guess you should add yourself to the reviewer not to the assignee!!!! Did that for you..

freaky4wrld avatar Mar 16 '24 06:03 freaky4wrld

Great job @danvgar at updating the files as specified issue's action items. Pull request is linked to the correct issue and the summary explains why these changes were made.

drakenguyen4000 avatar Mar 17 '24 05:03 drakenguyen4000