website
website copied to clipboard
Secured `wins.js` from XSS vulnerability by replacing `innerHTML`
Fixes #6303
What changes did you make?
- Updated 10 instances of
.innerHTML()
to use.textContent()
.
Why did you make the changes (we will use this info to test)?
- These changes protect against XSS vulnerabilities caused by using
.innerHTML()
.- 8 out of 10 instances were simple swaps.
- 2 out of 10 instances required further modifications to ensure original code intent and visual changes were preserved. Refer to text and history of commit 8b290112140ab3ff669f634c93ddabc6b885bc6c and commit 6d2ed907e83df62534ddeb40fe11895ecb8604c9 for further explanation
- Further reading on XSS vulnerabilities of
innerHTML
:
Screenshots of Proposed Changes Of The Website
- No visual changes to report.
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b danvgar-secure-winsjs-from-XSS-6303 gh-pages
git pull https://github.com/danvgar/website.git secure-winsjs-from-XSS-6303
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
https://github.com/danvgar/website/blob/secure-winsjs-from-XSS-6303/CONTRIBUTING.md
ETA: 48 hours
Review ETA: 3/16/24 Availability: 3/16/24
@Anahisv23 I guess you should add yourself to the reviewer not to the assignee!!!! Did that for you..
Great job @danvgar at updating the files as specified issue's action items. Pull request is linked to the correct issue and the summary explains why these changes were made.