website icon indicating copy to clipboard operation
website copied to clipboard

Updated message when no results from filter selection - issue 6299

Open raviteja4117 opened this issue 11 months ago • 7 comments

Fixes #6299

What changes did you make?

  • Updated message when no results from filter selections for Projects page made it singular forms from plural forms.
  • Updated message when no results from filter selections for Projects-Check page it singular forms from plural forms.

Why did you make the changes (we will use this info to test)?

  • Changed Projects and Project-check pages filter messages to deliver a message that makes sense

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2024-03-03 at 2 18 20 PM Screenshot 2024-03-03 at 2 18 36 PM
Visuals after changes are applied Screenshot 2024-03-03 at 2 18 57 PM Screenshot 2024-03-03 at 2 19 15 PM

raviteja4117 avatar Mar 03 '24 19:03 raviteja4117

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b raviteja4117-update-message-when-no-result-6299 gh-pages
git pull https://github.com/raviteja4117/website.git update-message-when-no-result-6299

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/raviteja4117/website/blob/update-message-when-no-result-6299/CONTRIBUTING.md  

github-actions[bot] avatar Mar 03 '24 19:03 github-actions[bot]

Availability: Weekdays ETA: 3/5/24

Thinking-Panda avatar Mar 04 '24 21:03 Thinking-Panda

Hi @elliot-d-kim

Thank you for your feedback and suggestions.

I've made the requested changes, including renaming the variable to "filterNameSingular" for clarity and adjusting the indentation to be consistent with the rest of the file.

I'm glad you found the hashmap solution easy to understand and appreciate your feedback on the variable naming.

Thank you

raviteja4117 avatar Mar 07 '24 03:03 raviteja4117

Hi @jphamtv

Thanks for pointing out those issues. I'm not sure how I missed them. I've fixed them now. Let me know if everything looks good.

Thank you

raviteja4117 avatar Mar 09 '24 01:03 raviteja4117

Hi @jphamtv

Thanks for Pointing out the search Display. I have fixed it Now. Please have a look at it. Thank you

raviteja4117 avatar Mar 10 '24 02:03 raviteja4117

Thanks @elliot-d-kim for the great suggestion to use filterNameSingular[key] ?? key as a fallback to make the function more robust and handle undefined cases nicely.

@raviteja4117, would you like to try implementing this change? If you get stuck or need any help, feel free to loop in @elliot-d-kim or myself, and we'll be happy to assist you.

jphamtv avatar Mar 11 '24 06:03 jphamtv

Thank you @elliot-d-kim and @jphamtv for the suggestions. @raviteja4117 Nice work. Looking forward to the requested code changes for a robust programming.

Thinking-Panda avatar Mar 11 '24 18:03 Thinking-Panda