website
website copied to clipboard
Adds tools filter to projects and projects-check pages
Fixes #6196
What changes did you make?
- Added Tools to filter list of Languages and Technologies on the Projects page
- Refactored createFilter function so that Tools would be combined on projects page rather than be it's own filter
Why did you make the changes (we will use this info to test)?
- To include Tools filter for projects and projects-check pages
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b sornekian-add-tools-6196 gh-pages
git pull https://github.com/sornekian/website.git add-tools-6196
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
https://github.com/sornekian/website/blob/add-tools-6196/CONTRIBUTING.md
Review ETA: EOD 3/3/24 Availability: 3/1/24 ~ 3/3/24
@luisitocanlas Yes you're absolutely right, I accidently removed that out. I just returned that bit and pushed again. Please review.
Good catch @Thinking-Panda.
@sornekian Looking forward to your updates, I'll be happy to review again then.
I'm having issues with this. The tools when bundled with languages and technologies shows up as (0) but if I put tools separately it works fine. Please see below image. I've tried looking up my issue but I can't seem to figure it out. Can I ask for some help? or if that's not how this works, I can drop the issue for someone else to work on.
@sornekian , You can sure ask for help. HackForLA community is to learn and grow together.
The filter frequency is added in the function updateFilterFrequency()
on line 390
.
While debugging try comparing onPageFilters
array and filterFrequencyObject
to figure out why the tools frequency is not updated.