website icon indicating copy to clipboard operation
website copied to clipboard

Add new fields to WINS Display Review and _wins-data.json

Open roslynwythe opened this issue 1 year ago • 26 comments

Dependency

  • [x] #4134

Overview

We need to create new fields to hold only GitHub and LinkedIn profile descriptors (in constrast to the current fields which contain complete URLs), and to incorporate those fields into the Response sheet, Review sheet, and the _wins-data.json feed.

Action Items

  • [x] Request VIEW access to the Wins Form Admin Guide Doc, the Wins-form (Response) Sheet, and gh-requests Doc from the dev lead
  • [x] Read the Wins Form Admin Guide[^1] to understand the flow of wins data.
  • [x] This issue will require modification of the code within the Wins-form (responses)[^2] sheet, but you will require a Google Drive test environment that includes copies of Wins-form (Responses)[^2] and gh-requests[^3]. It will also be necessary to setup a test environment in your GitHub repository. Follow instructions in the comment in the Hfla Google Apps Script Development Guide[^4] and Testing WINS in a test repository[^5]
  • [x] In the Response sheet, create two new columns GitHub-handle and LinkedIn-name
  • [ ] In insertLatestFormSubmitIntoReviewSheet populate the new columns with strings extracted from the submitted data in the GitHub URL and LinkedIn URL columns in the Response sheet.
  • [ ] Create new lines in the Review sheet and display the values of GitHub-handle and LinkedIn-name along with the submitted data for GitHub URL and LinkedIn URL
  • [ ] In main add code to include the GitHub-handle and LinkedIn-name fields in _wins-data.json
  • [ ] Test the code by running main() in debug mode. A new pull request "Update wins-data.json via Google Apps Script" should be appear in your test repository. Examine the json data and if it looks good, merge into your repository test branch and examine the resulting Wins page.
  • [ ] Add/commit Code.js and create a pull request as usual
  • [ ] In the pull request, provide links to the "Update wins-data.json via Google Apps Script" Pull Request and also the Wins page (both in your repository), for the convenience of reviewers.
  • [ ] Contact a dev lead to discuss review/demonstration

Resources/Instructions

roslynwythe avatar Sep 10 '23 10:09 roslynwythe

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] avatar Sep 10 '23 10:09 github-actions[bot]

@roslynwythe I moved this into the new issue review column because the dependency is resolved. Please add a ready for prioritization label if its ready.

ExperimentsInHonesty avatar Jan 24 '24 01:01 ExperimentsInHonesty

Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jan 29 '24 22:01 github-actions[bot]

Hi @Jung-GunSong, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Feb 16 '24 03:02 github-actions[bot]

i. I'm available throughout this and next week.

ii. By end of next week.

Jung-GunSong avatar Feb 16 '24 03:02 Jung-GunSong

@Jung-GunSong I have moved this issue to the in progress column. Next time you self assign, please remember to move the issue. 👍

ExperimentsInHonesty avatar Feb 16 '24 17:02 ExperimentsInHonesty

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Monday, February 19, 2024 at 11:06 PM PST.

github-actions[bot] avatar Feb 23 '24 07:02 github-actions[bot]

Here my update:

  1. I have not been able to work on this recently, and most of the work still needs to be done.
  2. Unknown at this moment.
  3. I will not be able to look into this project until the beginning of next week.
  4. Unsure until I can take a look at this again.
  5. N/A

I apologize for the lack of progress on this issue so far. Im the process of moving, and it made me busier than I thought. I will be able to give this my full attention next week.

I am also willing to unassign myself to this issue, someone wants to jump into this issue right now.

Jung-GunSong avatar Feb 26 '24 18:02 Jung-GunSong

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Monday, March 4, 2024 at 11:06 PM PST.

github-actions[bot] avatar Mar 08 '24 07:03 github-actions[bot]

Here is another update:

  1. I'm trying to see if I can get my winforms app script to run properly. This will be elaborated more in the blockers.
  2. I am getting an error when I try to run my test winforms app script, specifically with error code 401. I was able to make it work on the last issue I worked on it with, so I'm trying to see if my environment is set up properly.
  3. I'll have on average an hour a day to work on this throughout the week.
  4. I'll have a better ETA when this blocker is overcome, but hopefully by the end of next week at the latest.
  5. N/A

Jung-GunSong avatar Mar 11 '24 23:03 Jung-GunSong

Hi @Jung-GunSong were you able to get your test environment setup? If not, we could check your file permissions on Google Drive and re-share the documents. If you are making progress on this issue, please move it to "In Progress".

roslynwythe avatar Mar 21 '24 07:03 roslynwythe

Hi @roslynwythe I haven't been able to yet. I was thinking of popping into office hours today to get it resolved.

Jung-GunSong avatar Mar 21 '24 15:03 Jung-GunSong

@Jung-GunSong were you able to drop in on office hours?

ExperimentsInHonesty avatar Mar 26 '24 23:03 ExperimentsInHonesty

@ExperimentsInHonesty Hi Bonnie, I did drop in and I was asked to DM Roslyn about my blocker. We have been in communication and are working on it.

Jung-GunSong avatar Mar 27 '24 02:03 Jung-GunSong

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, April 23, 2024 at 12:06 AM PST.

github-actions[bot] avatar Apr 26 '24 07:04 github-actions[bot]

Hi @Jung-GunSong! Thanks for working on this issue. If you're still working, please add an update. If you're not able to continue to working on it, leave us a comment to let us know. If we don't hear from you soon, we will remove you from the issue. Thanks!

LRenDO avatar May 01 '24 20:05 LRenDO

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, April 30, 2024 at 12:06 AM PST.

github-actions[bot] avatar May 03 '24 07:05 github-actions[bot]

Hi @Jung-GunSong let me know if you are still able to work on this issue.

As I mentioned, I think the problem most likely has to do with your token. It is easy to have a mixup with the files containing the key, so I wanted to check, have you modified setToken so that it references the actual name of the file containing the key, like this: function setToken_() { let id; const files = DriveApp.getFilesByName('testgh-key-justin') while (files.hasNext()) { const file = files.next(); if (file.getName() === 'testgh-key-justin'){ id = file.getId(); } } because if you have not changed the file name appropriately, you may be retrieving the wrong token.

Also, it would be helpful for me to have your unencoded token. You can use a statement like: console.log(documentProperties.getProperty(TOKEN)) to print that out.

If you would like, we could schedule a meeting by zoom to work on this together.

roslynwythe avatar May 07 '24 23:05 roslynwythe

@LRenDO Hi Ren, sorry that I've been off the radar lately. I have will have more time to work on this issue in the next week or two. Sadly I have been stuck on getting the environment set-up. If my progress has been too slow, I can hop off the ticket to let someone else have a try at it.

Jung-GunSong avatar May 08 '24 03:05 Jung-GunSong

@roslynwythe Thank you for following up. I won't be able to look into this more seriously until next week. If that is too much time to wait, I can hop off to give someone else a try. Before the next week I will look into the token, and see if this would be an issue that needs to be fixed via zoom.

Jung-GunSong avatar May 08 '24 03:05 Jung-GunSong

ok thanks @Jung-GunSong

roslynwythe avatar May 09 '24 07:05 roslynwythe

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, May 21, 2024 at 12:06 AM PST.

github-actions[bot] avatar May 24 '24 07:05 github-actions[bot]

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, May 28, 2024 at 12:06 AM PST.

github-actions[bot] avatar May 31 '24 07:05 github-actions[bot]

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, June 4, 2024 at 12:06 AM PST.

github-actions[bot] avatar Jun 07 '24 07:06 github-actions[bot]

@Jung-GunSong I am moving this issue to the questions column, and adding the label ready for dev lead

ExperimentsInHonesty avatar Jun 09 '24 16:06 ExperimentsInHonesty

@Jung-GunSong For my testing, I had to change the name from gh-key to something else, because the code was finding another file with the name gh-key in my shared folders. So I would suggest that you change the name as well. By the way, I deleted your message because I don't want to expose your token. If that doesn't work then yes I think we should arrange to meet.

roslynwythe avatar Jun 14 '24 19:06 roslynwythe

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, July 30, 2024 at 12:05 AM PST.

github-actions[bot] avatar Aug 02 '24 07:08 github-actions[bot]

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, August 6, 2024 at 12:04 AM PST.

github-actions[bot] avatar Aug 09 '24 07:08 github-actions[bot]

@Jung-GunSong

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, August 13, 2024 at 12:14 PM PST.

HackforLABot avatar Aug 16 '24 19:08 HackforLABot

@Jung-GunSong please leave an update using the template above.

roslynwythe avatar Aug 19 '24 20:08 roslynwythe