website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon hackforla

Create a Github Action to verify Pull Requests are created by website team members

Open MattPereira opened this issue 2 years ago • 21 comments

Overview

As developers, we need to ensure that only members of our organization create pull requests to the hackforla / website repository. For this issue, we will add a github action that checks if the pull request creator is a member of the website team.

Action Items

  • [x] Learn how github actions work
  • [ ] Add a github action that checks if the creator of a pull request is a member of the website-write team
    • [ ] If the author is not a member of the website-write team, close the pull request with this comment:
You must be a member of the HFLA  website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started.  If you have been though onboarding, and feel this message in error, please message us in the #hfla-site team slack channel with the link to this PR.

Resources/Instructions

  • [ ] Wiki for writing new GHAs at HFLA: https://github.com/hackforla/website/wiki/HfLA-GitHub-Actions
  • [ ] Wiki for explaining HFLA GHA architecture: https://github.com/hackforla/website/wiki/Hack-for-LA's-GitHub-Actions

MattPereira avatar Jan 31 '23 23:01 MattPereira

Hi @KazushiR, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Apr 05 '23 22:04 github-actions[bot]

i. Availability: Weekdays ii. ETA: N/A. I am trying to figure out how Github Actions work. Will give weekly updates on my progress.

KazushiR avatar Apr 05 '23 22:04 KazushiR

Didn't realize this was in a draft file. Will be unassigning myself and moving this back new issue-approval

KazushiR avatar Apr 14 '23 02:04 KazushiR

@ExperimentsInHonesty If the GHA finds that a non-member has created a PR, perhaps the GHA should close the PR. Should I add that action to this issue?

roslynwythe avatar Sep 11 '23 23:09 roslynwythe

@roslynwythe how often does it happen? If its only occasionally, then we should double check them.

ExperimentsInHonesty avatar Nov 06 '23 21:11 ExperimentsInHonesty

@roslynwythe how often does it happen? If its only occasionally, then we should double check them.

You mean double-check in case the GHA action was incorrect and the contributor is in fact a member of Hack for LA? My main concern is that a bot comment in a PR is not all that visible and it may not come to the attention of the contributor or the merge team, unless we can do something to increase visibility, like make it appear in red or somehow give it an appearance similar to a failed GitHub check or a request for change.

roslynwythe avatar Nov 13 '23 08:11 roslynwythe

Agreed. Let's have it auto close the prs. Also lets add the same text in the close message on the pr template itself.

https://github.com/hackforla/website/blob/gh-pages/.github/pull_request_template.md

ExperimentsInHonesty avatar Nov 14 '23 02:11 ExperimentsInHonesty

Agreed. Let's have it auto close the prs. Also lets add the same text in the close message on the pr template itself.

https://github.com/hackforla/website/blob/gh-pages/.github/pull_request_template.md

@ExperimentsInHonesty I updated the issue so that if a pull request is created by a non-member, the PR is closed with a comment. I'm not sure I understand "Also lets add the same text in the close message on the pr template itself"

roslynwythe avatar Dec 10 '23 04:12 roslynwythe

@roslynwythe I have created an ER to address the remaining items on this issue (adding it to the pr template)

ExperimentsInHonesty avatar Jan 03 '24 23:01 ExperimentsInHonesty

Hi @roychan1, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jan 13 '24 05:01 github-actions[bot]

i. Availability: 8am-5pm ii. ETA: I am hoping to complete the ticket or at least make significant progress by 1/17 Wednesday.

roychan1 avatar Jan 13 '24 05:01 roychan1

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Monday, January 22, 2024 at 11:05 PM PST.

github-actions[bot] avatar Jan 26 '24 07:01 github-actions[bot]

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Monday, January 29, 2024 at 11:06 PM PST.

github-actions[bot] avatar Feb 02 '24 07:02 github-actions[bot]

  1. Progress: performing research on GitHub Actions
  2. Blockers: I have been preoccupied with other responsibilities
  3. Availability: this week
  4. ETA: 2 weeks

roychan1 avatar Feb 06 '24 06:02 roychan1

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Monday, February 12, 2024 at 11:05 PM PST.

github-actions[bot] avatar Feb 16 '24 07:02 github-actions[bot]

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Monday, February 19, 2024 at 11:06 PM PST.

github-actions[bot] avatar Feb 23 '24 07:02 github-actions[bot]

@roychan1 You need to give updates every week, or we unassign you from the issue.

ExperimentsInHonesty avatar Feb 28 '24 19:02 ExperimentsInHonesty

@roychan1 You need to give updates every week, or we unassign you from the issue.

I had been occupied and forgotten to provide updates or reassign the ticket, I apologize about that! I will be resuming my work on this issue and provide updates from now!

roychan1 avatar Feb 29 '24 02:02 roychan1

  1. Progress: continue performing research on GitHub Actions and begin implementing
  2. Blockers: I have been occupied with personal matters
  3. Availability: 9am-5pm
  4. ETA: 1 week

roychan1 avatar Feb 29 '24 02:02 roychan1

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Monday, March 4, 2024 at 11:06 PM PST.

github-actions[bot] avatar Mar 08 '24 07:03 github-actions[bot]

  1. Progress: continue performing research on GitHub Actions and begin implementing
  2. Blockers: busy schedule
  3. Availability: 8am-5pm
  4. ETA: 1 week

roychan1 avatar Mar 09 '24 09:03 roychan1

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, March 19, 2024 at 12:06 AM PST.

github-actions[bot] avatar Mar 22 '24 07:03 github-actions[bot]

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, March 26, 2024 at 12:06 AM PST.

github-actions[bot] avatar Mar 29 '24 07:03 github-actions[bot]

  1. Progress: continue performing research on GitHub Actions and begin implementing
  2. Blockers: I have been occupied with work
  3. Availability: 9am-5pm
  4. ETA: 1 week

roychan1 avatar Apr 04 '24 06:04 roychan1

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, April 9, 2024 at 12:06 AM PST.

github-actions[bot] avatar Apr 12 '24 07:04 github-actions[bot]

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, April 16, 2024 at 12:06 AM PST.

github-actions[bot] avatar Apr 19 '24 07:04 github-actions[bot]

@roychan1

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, April 23, 2024 at 12:06 AM PST.

github-actions[bot] avatar Apr 26 '24 07:04 github-actions[bot]

Hi @roychan1! It seems like you've got a lot going on right now which is totally okay. I am going to remove you from this issue for now. If you feel you can complete in the next two weeks feel free to add yourself back. Otherwise, feel free to take on another issue when your availability opens up. Thanks!

LRenDO avatar May 01 '24 20:05 LRenDO

Hi @ajb176, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar May 04 '24 07:05 github-actions[bot]

ETA: 3 weeks Availability: Evenings

ajb176 avatar May 04 '24 07:05 ajb176