website icon indicating copy to clipboard operation
website copied to clipboard

Change 'engineering.yml' to 'coding.yml' and edit the credits

Open neevliberman opened this issue 1 year ago • 6 comments

Fixes #3295

What changes did you make and why did you make them ?

  • Changed engineering.yml to coding.yml
  • Edited title, title-link, alt, used-in (and added content-type) attributes, and removed the type attribute
  • Credits page updated with new icon & credits, see below

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

(No associated credits were on the page)

Visuals after changes are applied

2nd row, right column

image

neevliberman avatar Aug 14 '22 18:08 neevliberman

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b neevliberman-coding-image-credit-3295 feature-homepage-launch
git pull https://github.com/neevliberman/website.git coding-image-credit-3295

github-actions[bot] avatar Aug 14 '22 18:08 github-actions[bot]

Availability: 6 Hours ETA: EOD 2022-08-17

arpitapandya avatar Aug 14 '22 20:08 arpitapandya

Availability: 4 hrs ETA: EOD 8/15/2022

jdingeman avatar Aug 15 '22 02:08 jdingeman

Hey @neevliberman. I am having trouble getting this into my local repo. I think your pull request needs to have hackforla:gh-pages, and not hackforla:feature-homepage-launch image

You may need to do another pull request with the correct branch, though I think @arpitapandya can speak on that with more confidence than I can.

jdingeman avatar Aug 15 '22 02:08 jdingeman

@jdingeman The original issue says: "The pull request created from this issue should be merged into feature-homepage-launch", so I did with that what I could... Not sure though, I could be wrong. Hopefully @arpitapandya can clear this up.

neevliberman avatar Aug 15 '22 04:08 neevliberman

Hey @neevliberman. I am having trouble getting this into my local repo. I think your pull request needs to have hackforla:gh-pages, and not hackforla:feature-homepage-launch image

You may need to do another pull request with the correct branch, though I think @arpitapandya can speak on that with more confidence than I can.

@jdingeman you may not be able to getting into your local repo because you don't have feature-homepage-launch branch locally if you haven't worked on feature-homepage-launch or may be deleted. This PR should be merged to feature-homepage-launch and not gh-pages as per the issue

Here is how I will review the PR

  • create a branch in your local repo feature-homepage-launch make sure its updated with the latest changes
  • Then follow the commands to review @neevliberman's PR PS: we have gh-pages and feature-homepage-launch branches which are separate so when you work on issue or review PR related to feature-homepage-launch make sure you have that locally and updated as you do for gh-pages.
  • Also, I will update branch on my github repo website prior to creating branch or making any changes to avoid the merge conflicts nocodingyml

arpitapandya avatar Aug 15 '22 05:08 arpitapandya

@neevliberman @arpitapandya oops that's embarrassing. Thank you for the correction. 😄 I managed to get it into my local repo and I'll review it.

ETA: EOD 8/17/22

jdingeman avatar Aug 17 '22 02:08 jdingeman