website icon indicating copy to clipboard operation
website copied to clipboard

Projects page copy with only technology and language filters

Open Wny-Duong opened this issue 1 year ago • 4 comments

Fixes #2502

What changes did you make and why did you make them ?

  • Created a copy of the projects page that is accessible through a /projects-check/ permalink and is only accessible through permalink. It can't be reached simply by pressing the project button, only through http://localhost:4000/projects-check/ when checking locally.
  • On projects-check, there are only two filters, technologies and languages. They follow the same behavior as the default projects page filters.
    • Example 1: Selecting multiple technologies in only the technologies filter will increase the number of projects returned, as cards containing any of the selected technologies are shown.
    • Example 2: Selecting a technology filter and a language filter will restrict the number of projects returned, as it checks only for projects that contain both the specific technology and language.
    • The separated technologies and languages filter contain the same filter items as the combined technologies/languages filter used in the default projects page.
  • Note: The new files added were based off of the current-projects.html, current-projects.js, and projects-page.html files used to generate the current projects page. The html files are identical with changes to the file names referenced to ensure a separate working projects-check page. The projects page is still accessible through /projects/ and uses the old filters currently used (program areas, languages/tech, status).

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Wny-Duong avatar Aug 07 '22 18:08 Wny-Duong

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Wny-Duong-projects-check-page-2502 gh-pages
git pull https://github.com/Wny-Duong/website.git projects-check-page-2502

github-actions[bot] avatar Aug 07 '22 18:08 github-actions[bot]

ETA: End of Day on 8/15 Availability: 4 hours

kathrynsilvaconway avatar Aug 10 '22 02:08 kathrynsilvaconway

Availability: 6 Hours ETA: EOD 2022-08-11

arpitapandya avatar Aug 10 '22 02:08 arpitapandya

ETA: Aug. 14

Zak234 avatar Aug 13 '22 20:08 Zak234

I may be wrong but it looks like there are 65 combined languages and technologies in the new page and only 62 in the old page.

I looked into this and you're right, there are 3 more languages that were added because of my changes: Makefile Ruby Svelte

These languages do show up in the project cards for the old projects page, but aren't included in the original combined languages and technologies filter. I'm not too sure why this is and I don't know if this is something that should be fixed since it technically corrects the problem of those languages not showing up in the filter in the first place.

Wny-Duong avatar Aug 16 '22 17:08 Wny-Duong

We could probably bring it up during office hours tomorrow

Zak234 avatar Aug 17 '22 17:08 Zak234

Sounds good to me. I'll see you there.

Wny-Duong avatar Aug 17 '22 17:08 Wny-Duong

@Zak234 From the office hours, it looks like the new languages are fine, but there might be a need to make a new issue addressing the fact that the old Projects filters were missing the Makefile, Ruby, and Svelte language filter options since those languages are listed in some of the project cards currently existing on the Projects page.

Just leaving a note here that the changes made found three new languages that weren't previously included under the Projects page Languages/Technologies filter along with some images in case a new issue needs to be created.

Image from the projects-check language filter: image

Images from the old projects filter: image

Project cards using Ruby, Svelte, and Makefile on the old projects page included: Spare Write for All Work for LA BallotNav

Wny-Duong avatar Aug 19 '22 02:08 Wny-Duong

Here is the issue @blulady created to request documentation: #3487

kathrynsilvaconway avatar Aug 26 '22 00:08 kathrynsilvaconway