website icon indicating copy to clipboard operation
website copied to clipboard

Refactor CSS for Home Page Footer on Smaller Screens for Redesigned Homepage

Open Zak234 opened this issue 2 years ago • 1 comments

Overview

Currently, when you compress the Home page on a computer screen, the CSS for mobile doesn't activate leading to weird formatting. We need to update the CSS so that the mobile CSS is activated for the compressed Home Page to ensure the intended formatting.

Action Items

Resources/Instructions

Current Home Page: Screen Shot 2022-07-28 at 10 37 53 AM Intended Home Page: Screen Shot 2022-07-28 at 10 38 08 AM

Files: _footer.scss _footer.html How to work off of a feature branch Homepage Redesign Credits in Figma

Zak234 avatar Jul 28 '22 17:07 Zak234

@Zak234 Thanks for writing this issue! There were a couple things I noticed:

  1. The footer on the feature-homepage-launch branch looks like this

    Click here to see what the footer looks like on the redesigned homepage Footer-redesigned-homepage-mobile
    This is from changes implemented from part of this pull request #3183. **Note:** Some of the links do not work because the anchors have not been implemented yet for some of the menu items.
  2. I noticed your links to the _footer.scss and _footer.html are for the code in the gh-pages branch. If the developer is going to be working off the feature-homepage-launch branch for this issue, I recommend you link to the code in the feature-homepage-launch because the code for these files in feature-homepage-launch branch are different from the files in gh-pages.

JessicaLucindaCheng avatar Aug 08 '22 19:08 JessicaLucindaCheng

@Zak234 Jessica sent you a message about this issue, bumping this back into your inbox

ExperimentsInHonesty avatar Sep 11 '22 16:09 ExperimentsInHonesty

@Zak234 Hi, Sakari. Is this issue ready to be approved, or are you still working on it? Please let me know if you need any help this so I can get it approved and in the queue.

kathrynsilvaconway avatar Sep 13 '22 04:09 kathrynsilvaconway

Sakari seems to have left the project. Please review his issue and Jessica's comments and prepare the issue for milestone

ExperimentsInHonesty avatar Oct 24 '22 22:10 ExperimentsInHonesty

Great eye as always @JessicaLucindaCheng!! I believe I have made the corrections she recommended. Linking to the eature-homepage-launch _footer.scss and _footer.html as well as replacing the image. Did I replace it with the right image from figma? This was the image under option 2 in the red square? I didn't see anything labeled feature-homepage-launch....

blulady avatar Oct 25 '22 03:10 blulady

@blulady Thanks for making the changes! Remember to remove the Draft label off of an issue when you add a Ready for Milestone label on it. I went ahead and did it this time.

I replaced the image of the current redesigned homepage footer with a gif to illustrate the problem better and because the original image was out of date.

JessicaLucindaCheng avatar Oct 26 '22 08:10 JessicaLucindaCheng

@JessicaLucindaCheng Thank you!! We need all the help we can get.

blulady avatar Oct 26 '22 15:10 blulady

Hi @PeterSYoo, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Nov 01 '22 22:11 github-actions[bot]

i. Availability: 4pm-5pm PST 11/01/22 ii. ETA: 11/03/22

PeterSYoo avatar Nov 01 '22 22:11 PeterSYoo

Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

P.S. Please remember to always move your issue to the "In Progress" column when you self-assign. We have moved this issue for you.

bishrfaisal avatar Nov 14 '22 17:11 bishrfaisal

Blockers: I'll be joining a hackathon from Nov 16 - Nov 21, but I'll be available again from Nov 21st!

PeterSYoo avatar Nov 16 '22 03:11 PeterSYoo

@PeterSYoo

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, November 21, 2022 at 11:17 PM PST.

github-actions[bot] avatar Nov 25 '22 07:11 github-actions[bot]

Hi @h3nry-m, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Nov 29 '22 07:11 github-actions[bot]

Hi all! i. Availability: During the work week evenings ii. ETA: Just sent a pull request. Please review and let me know if I understood the objective correctly.

h3nry-m avatar Nov 30 '22 01:11 h3nry-m

Review availability: Weekdays 10-12pm ETA: 12/26 5pm

Jaretzbalba avatar Dec 20 '22 23:12 Jaretzbalba

Hi @Jaretzbalba, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Dec 20 '22 23:12 github-actions[bot]

  • Merged pull request #3774 fixes this issue

JessicaLucindaCheng avatar Feb 07 '23 00:02 JessicaLucindaCheng