website
website copied to clipboard
Fixes #2220
Fixes #2220
What changes did you make and why did you make them ?
Implemented solutions as suggested in https://github.com/hackforla/website/issues/2220:
- Renamed 'add-update-label-weekly.yml'' to 'schedule-fri-0700.yml'' and updated 'name' env variable to Schedule Friday 0700
- Moved add-update-label-weekly directory to already existing /github-actions/trigger-schedule/ directory
- Updated path to respective add-label.js to reflect current directory structure
Much of the changes are purely for organizational purposes to better maintain the workflows/actions created
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No changes since the directories were reorganized and minor changes were made to accompanying files to better maintain code. Function remains same.
NOTE: One thing to mention is that I'm not entirely sure how to locally test a github action/workflow. If anyone knows, please let me know! I've found this tool neko which but I haven't used/tested it myself yet.
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b poorvi4-add-update-label-restructure-2220 gh-pages
git pull https://github.com/poorvi4/website.git add-update-label-restructure-2220
Availability: 6 Hours ETA: EOD 2022-07-26
Availability: 5 Hours ETA: EOD 2022-07-25
Where do we test it? Any specific tool? @BeckettOBrien @poorvi4
The Act from Nektos tool does look really helpful. Did you try it @BeckettOBrien?
I did, but so far I only tested it on a different action because I'm still figuring out how to trigger specific scheduled actions or if I have to temporarily add a workflow_dispatch first.
Hey @poorvi4 sorry, I am working on it, I am actually waiting on the GitHub action testing demo as discussed during our last team meeting as I am also having issues in testing. Once we figure that out I will review it. You may ask the team lead if you have to work on next issue since I holding this off for a while.
Oh good catch! I updated the pull request so the add-update-label file should be correctly renamed to schedule-fri-0700
I think the problem is that line 302 is
const path = './github-actions/add-update-label-weekly/update-instructions-template.md'
and it should be
const path = './github-actions/trigger-schedule/add-update-label-weekly/update-instructions-template.md'
Hey @poorvi4, just wondering if you are still going to be able to finish this pull request. Please post an update or let us know if you won't be able to continue working on the PR.
Hi sorry for the delay I’ll finish it up in the coming days
@Zak234 @blulady Hi all, I updated the path as per Sakari's suggestion so everything should be good to go!
Reached out to Poorvi on slack as well. No response. Putting this back into the new issue approval.