website icon indicating copy to clipboard operation
website copied to clipboard

Homepage redesign: Add anchor to Get In Touch section

Open JessicaLucindaCheng opened this issue 2 years ago • 10 comments

Overview

As a developer, I want to be able to go directly to the Get In Touch section on the redesigned homepage so that I can quickly and easily go to that section without scrolling. For this issue, we will add an anchor to the Get In Touch section.

Details

Screenshot of Get in Touch Section on the Redesigned Homepage

get-in-touch

Action Items

  • [x] Feature Branch: You will be working off a feature branch called feature-homepage-launch and the pull request created from this issue should be pushed into that feature branch. Please read and follow the steps in the How to work off of a feature branch wiki article.
  • [x] Before line 1 in _includes/forms/contact-us.html, add <a class="anchor" id="get-in-touch"></a> so that
    <section class="home--contact home--section">
    
    becomes
    <a class="anchor" id="get-in-touch"></a>
    <section class="home--contact home--section">
    
  • [x] Using Docker, check that going to localhost:4000/#get-in-touch jumps to the Get In Touch section on the homepage
  • [ ] Once the pull request associated with this issue is approved and merged,
    • [x] Please update and edit issue https://github.com/hackforla/website/issues/2393 by
      • [x] Checking off the dependency for this issue
      • [x] If all dependencies are checked off, please move issue https://github.com/hackforla/website/issues/2393 to the New Issue Approval column and remove the Dependency label
    • [x] Please update and edit issue #2455 by
      • [x] Checking off the dependency for this issue
      • [x] If all dependencies are checked off, please move issue #2455 to the New Issue Approval column and remove the Dependency label

Resources/Instructions

  • https://github.com/hackforla/website/blob/467a797f7c9518fcb466b6bdd034de27050b838e/_includes/forms/contact-us.html#L1
  • Example page that has anchors: https://www.hackforla.org/about
  • Tracked in https://github.com/hackforla/website/issues/2481#issuecomment-968349924
  • Related to issues
    • https://github.com/hackforla/website/issues/2393
    • https://github.com/hackforla/website/issues/2455

JessicaLucindaCheng avatar Apr 01 '22 05:04 JessicaLucindaCheng

Hi @JessicaLucindaCheng.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] avatar Apr 01 '22 05:04 github-actions[bot]

@KazushiR are you no longer working on this issue? I can see that you assigned yourself to it, moved it from the prioritized backlog to inprogress and then removed it from the board entirely and you're still assigned to it.

Additionally on another issue #3016 , it looks like you removed it from the prioritized backlog and the project board.

Also in #2961, you assigned yourself, added a milestone and then unassigned yourself from the issue

Please explain what you're trying to accomplish in both issues so that we can help you.

@JessicaLucindaCheng @SAUMILDHANKAR

Providence-o avatar Apr 12 '22 18:04 Providence-o

@KazushiR are you no longer working on this issue? I can see that you assigned yourself to it, moved it from the prioritized backlog to inprogress and then removed it from the board entirely and you're still assigned to it.

Additionally on another issue #3016 , it looks like you removed it from the prioritized backlog and the project board.

Also in #2961, you assigned yourself, added a milestone and then unassigned yourself from the issue

Please explain what you're trying to accomplish in both issues so that we can help you.

@JessicaLucindaCheng @SAUMILDHANKAR

Apologies. I was trying to assign myself to an issue that I could work on. I will be working on this issue. Apologies on the confusion.

Availability: 4/15/22 10AM - 2PM ETA: 4 Hours

KazushiR avatar Apr 13 '22 03:04 KazushiR

@KazushiR At the time you self-assign an issue, please move the issue from the "Prioritized Backlog" to the "In Progress" column. For detailed instructions, see 2.4.b Move this issue from the ‘Prioritized Backlog’ to the ‘In progress’ & back in the CONTRIBUTING.md.

JessicaLucindaCheng avatar Apr 13 '22 23:04 JessicaLucindaCheng

@KazushiR Just wanted to remind you that a medium issue should be picked up once your small issue has been merged. Please see the following link for the reasons of this progression: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#21-hack-for-la-contributor-expectations. Therefore, requesting you to please pick up a medium issue next once this one has been merged. Also, please move the issue to In-progress column as suggested by Jessica in a comment above. We can go over how to pick up an issue and further steps in our next team meeting break-out room if required. Please let me know.

SAUMILDHANKAR avatar Apr 16 '22 04:04 SAUMILDHANKAR

@KazushiR As per our last discussion, unassigning you from this issue so you could pick up a medium issue next which would be more in line with your issue progression. But if you feel like you have already done substantial amount of work for this issue and would like to finish it before moving on to the next issue, you can pick up this issue again instead and work on it. I will leave it up to you, but please work on only one issue at a time. Thank you.

SAUMILDHANKAR avatar May 08 '22 16:05 SAUMILDHANKAR

@geedtd At the time you self-assign an issue, make sure to write in a comment the following:

  • Availability: "How much time will you have this week to work on this issue?"
  • ETA: "When do you expect this issue to be completed?"

JessicaLucindaCheng avatar Jun 24 '22 00:06 JessicaLucindaCheng

@geedtd Hi, I am unassigning you from this because we haven't heard from you in quite a while. If you would still like to be a part of the HFLA dev team, you can reassign yourself and update your status.

kathrynsilvaconway avatar Jul 25 '22 21:07 kathrynsilvaconway

Hi @CalvinTan607, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Aug 10 '22 00:08 github-actions[bot]

i. Availability: 8/9 - 8/10 ETA: By the end of 8/9

CalvinTan607 avatar Aug 10 '22 00:08 CalvinTan607