website
website copied to clipboard
Google Apps Script: Fix data errors in spreadsheet used for wins page
Overview
The data used to generate our wins page should be error free. For this issue, we will analyze and fix the data discrepancies between the responses and review sheets used to build the wins page.
Action Items
- [x] Obtain access to the Google Apps Script in the admin drive from the technical lead
- [x] Become familiar with the workflow process in creating a wins entry
- [x] In the admin drive, create a copy of the Wins-form (Responses) and Secret files in your own drive to recreate the workflow
- [x] Identify the reason for data discrepancy between the responses and review sheets
- [x] Fix the code logic so that the data is consistent amongst various sheets
- [x] Add an error catching mechanism so that error like this is not repeated again
- [ ] From this comment, fix the following problems:
- [ ] In the _wins-data.json and wins-data.json at the end of each Wins entry, there is
"":""
, which wasn't there in the current _wins-data.json and current wins-data.json in gh-pages. - [x] There is something wrong with the Wins spreadsheet, where Wins form entry made on 11/5/2021 wasn't added to the Review sheet and so the true/false in the "Display?" and "Homepage?" are off.
- [ ] In the _wins-data.json and wins-data.json at the end of each Wins entry, there is
- [x] Test the code so that on a new form submit, both the Review sheet and Responses sheet gets updated appropriately
- [ ] Demo the code to the technical lead and team
For merge team:
- [ ] Once approved, update the current production code
- [ ] Release dependency on #2385 and #2505
- [ ] Update action items in the dependency issue if needed
Resources/Instructions
Google Apps Script _wins-data file wins page JS Response sheet
Hi @SAUMILDHANKAR.
Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.
Additional Resources:
ETA: March 23 Availability: Monday, Tuesday, Wednesday from 4 pm - 5 pm, Saturday and Sunday 10 am - 12 pm
Updated ETA and Availability: ETA: March 28 Availability Friday, Saturday, Sunday 1-2 hours each day Progress: Got access to Drive folder, I plan to really get going on this during the weekend Blockers: None
@luke-karis Thanks for providing an updated ETA and availability but if you are providing a progress update please also include Progress and Blockers. Here is more information about providing a progress update: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#25-reporting-progress-on-your-issue
Once you have completed a progress report that includes progress, blocker, availability, and ETA, you can check off that item in your pre-work checklist and then check off the "Once all tasks are completed, close this issue." task and then close your pre-work issue. Thanks.
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures: "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, March 29, 2022 at 12:20 AM PST.
Updated ETA and Availability: ETA: April 8 Availability: Monday, Tuesday, Wednesday, Thursday 4-5/5:30 pm Progress: Started working on figuring out what the issue is Blockers: none
ETA and Availability: ETA: April 18 Availability: Tuesday 5:00-7:00, Thursday 4:00-5:00, Saturday and Sunday 10:00-12:00 Blockers: Kinda, but a little hard to articulate. I'm going to work more on this on Tuesday and hopefully come up with blockers to bring up a stand up.
@SAUMILDHANKAR I changed your Action Item
- [ ] Make sure the issues mentioned in the following comment are resolved: https://github.com/hackforla/website/pull/2765#issuecomment-1036942313
to
- [ ] From this comment, fix the following problems:
- [ ] In the _wins-data.json and wins-data.json at the end of each Wins entry, there is
"":""
, which wasn't there in the current _wins-data.json and current wins-data.json in gh-pages.- [ ] There is something wrong with the Wins spreadsheet, where Wins form entry made on 11/5/2021 wasn't added to the Review sheet and so the true/false in the "Display?" and "Homepage?" are off.
This removes the problem "Also, for _wins-data.json, UniqueID shouldn't be there yet because the Google Apps Script related to issue https://github.com/hackforla/website/issues/2385 hasn't been added to the product script.", which needs to be addressed in a separate issue.
ETA and Availability Update: ETA: 4/27 Availability: Sunday 4/25 - Wednesday 4/27 for 1-2 hours each day (assuming I'm feeling better) Blockers: I'm been feeling a little sick this past week so I haven't made a lot of progress on this. Hopefully I'll feel better soon and be able to work on this during my availability.
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures: "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, April 26, 2022 at 12:21 AM PST.
ETA and availability update: Progress: Started working on the scripts in the admin drive rather than my janky copy and pasted one. Unfortunately not too much other progress to report ETA: 5/9/22 Availability: Monday 1 hour, Tuesday 1-2 hours, Wednesday (maybe) 1 hour, Saturday and Sunday 1-2 hours Blockers: none
@luke-karis Please provide a progress update with Progress, Blockers, Availability, and ETA
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures: "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, May 10, 2022 at 12:23 AM PST.
ETA and Availability Update: ETA: 5/25 Availability: Monday, Tuesday 1-2 hours Blockers: None
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures: "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, May 24, 2022 at 12:21 AM PST.
ETA and Availability Update: ETA: 6/7/22 Availability: Thursday, Friday, Saturday, Sunday, Monday, Tuesday 1-2 hours Blockers: None
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures: "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, June 7, 2022 at 12:21 AM PST.
ETA and Availability Update: ETA: 6/21/22 Availability: Wednesday 1.5-2 hours, Saturday 1 hour, Sunday 2-3 hours, Monday all damn day if I need to Blockers: None
ETA and Availability Update ETA: June 28 Availability: Friday, Saturday, Sunday 2-3 hours Blockers: None
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures (optional): "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, June 28, 2022 at 12:21 AM PST.
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures (optional): "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, July 5, 2022 at 12:19 AM PST.
ETA and Availability Update ETA: July 15 Availability: Tuesday, Thursday 1-2 hours Blockers: None
ETA and Availability Update ETA: July 21 Availability: Wednesday, Thursday 1-2 hours Blockers: None
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures (optional): "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, July 26, 2022 at 12:20 AM PST.
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures (optional): "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, August 2, 2022 at 12:20 AM PST.
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures (optional): "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, August 9, 2022 at 12:20 AM PST.
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures (optional): "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, August 16, 2022 at 12:21 AM PST.
ETA and Availability Update ETA: August 23 Availability: N/A Blockers None
This is done I just need the go ahead to actually implement my code changes in the main scripts. Hopefully I will be able to do that at this Tuesday's meeting
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures (optional): "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, August 30, 2022 at 12:27 AM PST.
@luke-karis
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures (optional): "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, September 6, 2022 at 12:28 AM PST.