website icon indicating copy to clipboard operation
website copied to clipboard

Edit content field and remove type field from meetup.yml credits file

Open answebdev opened this issue 3 years ago • 4 comments

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.

Details

Currently, in each credit's yml file, there is a content field and a type field, which contains similar information. Since the fields are redundant, we decided to remove the type field.

Also, we changed the content field to the content-type field to make it clearer what its purpose is. The possible values for content-type field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.

Action Items

For the file _data/internal/credits/meetup.yml, do the following:

  • [ ] Change line 4 for the content field from
    content: icon
    
    to
    content-type: image
    
  • [ ] Remove line 11 for the type field
    type: icon
    
  • [ ] Once the pull request associated with this issue is approved and merged, please update and edit epic #2775 by
    • [ ] Checking off the dependency for this issue
    • [ ] If all dependencies are checked off, please move issue #2775 to the New Issue Approval column and remove the Dependency label

Resources/Instructions

  • This issue is tracked in the epic #2775.

File and Code links you will need to work on this issue

  • Directory to find the page in once you have it in your IDE: _data/internal/credits/meetup.yml

  • Click on the links below to see the source file code: https://github.com/hackforla/website/blob/7164ec247825adca279d4fd99fa52895335badbb/_data/internal/credits/meetup.yml#L4 https://github.com/hackforla/website/blob/7164ec247825adca279d4fd99fa52895335badbb/_data/internal/credits/meetup.yml#L11

answebdev avatar Feb 22 '22 23:02 answebdev

Hi @answebdev.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] avatar Feb 22 '22 23:02 github-actions[bot]

Hi @gstemmann, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Oct 12 '22 03:10 github-actions[bot]

ETA: October 20, 2022 Availability: 6 hours per week

gstemmann avatar Oct 12 '22 03:10 gstemmann

Hi @esantiano, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Oct 14 '22 01:10 github-actions[bot]

@esantiano

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 11, 2022 at 12:39 AM PST.

github-actions[bot] avatar Oct 14 '22 07:10 github-actions[bot]

Availability for this week: 10AM-1PM EST My estimated ETA for completing this issue: 11AM EST

esantiano avatar Oct 14 '22 14:10 esantiano

How many hours did it take you to finish the pre-work up to and including adding your initial ETA and availability for your good first issue, including attending your first meetings? 3 hours to finish pre-work + initial ETA and availability on good first issue. 2 hours for meetings.

esantiano avatar Oct 14 '22 15:10 esantiano