website
website copied to clipboard
Edit content field and remove type field from environmental-impact.yml credits file
Prerequisite
- Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
- Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.
Overview
As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.
Details
Currently, in each credit's yml file, there is a content
field and a type
field, which contains similar information. Since the fields are redundant, we decided to remove the type
field.
Also, we changed the content
field to the content-type
field to make it clearer what its purpose is. The possible values for content-type
field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.
Action Items
For the file _data/internal/credits/environmental-impact.yml
, do the following:
- [x] Change line 4 for the content field from
tocontent: Image
content-type: image
- [x] Remove line 11 for the type field
type: icon
- [x] Once the pull request associated with this issue is approved and merged, please update and edit epic #2775 by
- [x] Checking off the dependency for this issue
- [x] If all dependencies are checked off, please move issue #2775 to the New Issue Approval column and remove the Dependency label
Resources/Instructions
- This issue is tracked in the epic #2775.
File and Code links you will need to work on this issue
-
Directory to find the page in once you have it in your IDE:
_data/internal/credits/environmental-impact.yml
-
Click on the links below to see the source file code: https://github.com/hackforla/website/blob/2443b6c47df54ca678a432035beb93f1e2e3b94e/_data/internal/credits/environmental-impact.yml#L4 https://github.com/hackforla/website/blob/2443b6c47df54ca678a432035beb93f1e2e3b94e/_data/internal/credits/environmental-impact.yml#L11
Hi @tamara-snyder.
Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.
Additional Resources:
Hi @RobenusW, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
Availability: Tuesday-Thursday, Sunday ETA: Sunday, July 3rd
How many hours did it take you to finish the pre-work up to and including adding your initial ETA and availability for your good first issue, including attending your first meetings?
About 3 weeks
@RobenusW
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
- Progress: "What is the current status of your project? What have you completed and what is left to do?"
- Blockers: "Difficulties or errors encountered."
- Availability: "How much time will you have this week to work on this issue?"
- ETA: "When do you expect this issue to be completed?"
- Pictures (optional): "Add any pictures of the visual changes made to the site so far."
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.
You are receiving this comment because your last comment was before Tuesday, July 5, 2022 at 12:19 AM PST.
Progress: I am a little behind Blockers: "Difficulty making edits, because when typing on VSCODE the edits dont showup on my branch Availability: 1 and half hours ETA: Tuesday of next weeks
Sorry about the delay, I have just been busy personally, I promise to get back on track
Progress:Just need to check off dependencies Blockers: Just waiting for merging Availability: 1 and half hours ETA: Sunday of this week, if not sooner
@RobenusW I noticed you moved this back to new issue approval. Are you trying to unassign yourself from the issue?
Submitted PR for this issue. I spent about an hour on this.
Moving this issue to Prioritized Backlog as changes have not been made and issue hasn't been worked on since September 2022.
Hi @mademarc, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
Availability: 4/5/2023 ETA: 4/7/2023
Hi @StephenTheDev1001, thank you for taking up this issue! Hfla appreciates you :)
Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)
You're awesome!
P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)
Availability: 3/30/2023 ETA: 3/30/2023