tdm-calculator icon indicating copy to clipboard operation
tdm-calculator copied to clipboard

Implement Server-Side Request Validation and API endpoint tests

Open entrotech opened this issue 1 year ago • 2 comments

Dependency:

This issue tracks all sub issues below. It can be closed upon completion of all sub issues

Overview

A best practice is for the Web API server to verify that the body of all requests meet appropriate validation criteria. We need to create a workflow for testing all endpoints. We will need to set up tests and web API request validation for the endpoints.
Each route must complete the following:

  • Identify overexposed public surface and delete (i.e. remove any unnecessary/stale code as there are may be endpoints for features that will never be used)
  • Write tests for all endpoints for a given route. Confirm there is documentation for testing
  • Server side validation schema must be set up for the endpoints

Action Items

Routes:

  • [x] #1400
  • [x] #1499
  • [x] #1554
  • [x] #1581
  • [x] #1625
  • [ ] #1624
  • [x] #1629

Resources/Instructions

Server Side Validation

  • https://www.npmjs.com/package/express-json-validator-middleware
  • https://simonplend.com/how-to-handle-request-validation-in-your-express-api/

Testing

entrotech avatar Aug 25 '22 01:08 entrotech