shared-housing icon indicating copy to clipboard operation
shared-housing copied to clipboard

Front end is making the wrong call to the backend in the demo section

Open joshRamirez opened this issue 5 years ago • 2 comments

Overview

Front end is making a PUT request to /candidate. The method type is POST (since we are creating a new candidate resource, not updating an existing one).

Action Items

Change the frontend's call's HTTP method type from PUT to POST for the demo's add a new candidate button.

Also, the call does not populate the name. The request payload looks like {name: ""} when I entered joshua. It should be {name: "joshua"} (also I thought the key should also be in quotes? I may be mistaken.)

Resources/Instructions

n/a FYI architecture is being discussed/designed and is subject to change. This change will get the demo part for adding a candidate working again.

additional info from the network tab in the browser tools: Request URL: http://smileapp.ivan-alpha.xyz/api/candidates/ Request Method: PUT Status Code: 404 NOT FOUND

Related to #202 #75

joshRamirez avatar Nov 21 '19 05:11 joshRamirez

@tylerthome I don't think I can assign anyone. This is the ticket I was referencing in slack

joshRamirez avatar Nov 21 '19 07:11 joshRamirez

now that the commits PR #232 are merged we can create a more stable convention for calling from the client.

@itsevalieu @kkchu791 @wsbuck @lindamejia we can make tickets for subtasks on this or just consider it a single issue to build support for the new REST API.

tylerthome avatar Dec 04 '19 22:12 tylerthome