food-oasis
food-oasis copied to clipboard
hackforla
moved attribution icon to top left
- Closes #2022
- New
https://github.com/hackforla/food-oasis/assets/843538/7adebc79-34e7-47d1-b633-43fc53ad6c89
- Old
https://github.com/hackforla/food-oasis/assets/843538/a3720b91-c73d-433d-b5ce-c47fe9aef42f
is this where we want it to be? 🤔 it looks like it's colliding with the advanced filters
is this where we want it to be? 🤔 it looks like it's colliding with the advanced filters
@hanapotski Thank you for catching that. @JohnHaoHuang Hi John, please guide us on the design/layout for the icons as seen in the image. Thank you.
If we do not show the map in full list view, can we omit the the info and mapbox icon? @SAUMILDHANKAR
If we do not show the map in full list view, can we omit the the info and mapbox icon? @SAUMILDHANKAR
@JohnHaoHuang Thank you so much for your prompt reply. Sharing the resource for attribution requirements: https://docs.mapbox.com/help/dive-deeper/attribution/, please notice where it mentions Maps using Mapbox map styles or data supplied by Mapbox must display both the Mapbox logo and text attribution.
Our full list view does have tiny portion of map still visible so my understanding is to keep both logo and text attribution. Are you suggesting changes to our full list view? Please let us know your thoughts. Thank you.
@SAUMILDHANKAR Sorry for the delay. Please view the solution in Figma under March 16, 2024 update. Let me know if you have any other questions. Thanks.
https://www.figma.com/file/9hPmNSsyaH2VMGNz5mffmI/FOLA-Design-%232?type=design&node-id=640%3A125&mode=design&t=Jw7eBJxEJqr9e5x6-1
@SAUMILDHANKAR Sorry for the delay. Please view the solution in Figma under March 16, 2024 update. Let me know if you have any other questions. Thanks.
https://www.figma.com/file/9hPmNSsyaH2VMGNz5mffmI/FOLA-Design-%232?type=design&node-id=640%3A125&mode=design&t=Jw7eBJxEJqr9e5x6-1
@JohnHaoHuang Thank you so much for sharing the design on Figma. Also need your help on the design for when the info icon is pressed. Please notice that on pressing the info icon some additional text appears as shown in the following clip:
https://github.com/hackforla/food-oasis/assets/843538/7adebc79-34e7-47d1-b633-43fc53ad6c89
My question is (as per your design) do we push the mapbox logo to the right when info icon is pressed? Another approach could be to have the info icon to the right of mapbox logo.
@SAUMILDHANKAR, Please review the new design in figma. Let me know if you have any questions. Thank you.
https://www.figma.com/file/9hPmNSsyaH2VMGNz5mffmI/FOLA-Design-%232?type=design&node-id=640%3A125&mode=design&t=CHUVPwP7awyJemzQ-1
As per the design recommendation in Figma,
- Added 2.23px padding on top of info icon to make the gap between logo svg and icon 8 px.
- Fixed the y position of draggable component at 60px so that the gap between the button in advanced filter and the logo svg is 16px (since window.innerheight changes with device type). Adjusted the y position within handlestop as well.
@junjun107 Thanks for helping with rulers.
https://github.com/hackforla/food-oasis/assets/843538/40645cb3-f9ea-4206-8563-dcb3b857a506
@hanapotski @qiqicodes Thank you for helping me on adding the padding, using ternary operator and using stack in place of grid. Requesting your review. Please see the following clip for the latest changes. Thank you.
https://github.com/hackforla/food-oasis/assets/843538/62be50d1-efa3-4316-8ca3-e285b0cf1b87
@andyarensman Thank you so much for your review and approval.
@JohnHaoHuang Hi John, just wanted to share with you that the design request for mapbox logo and icon has now been merged to dev branch. Feel free to take a look at the mobile view on https://devla.foodoasis.net/organizations. Following clip shows the same as well. Hope it is fine. Thank you.
https://github.com/hackforla/food-oasis/assets/843538/62be50d1-efa3-4316-8ca3-e285b0cf1b87