food-oasis icon indicating copy to clipboard operation
food-oasis copied to clipboard

Bug: Request Assignment Does not get Meal Pantries

Open entrotech opened this issue 2 years ago • 2 comments

Overview

On the Volunteer Dashboard, the Request Assignment button will get an assignment for Food Pantries and Farmers Markets, but it should get Food Pantries and Meal Programs that are not permanently closed and currently in the Needs Verification state.

Action Items

  • [ ] Fix

Resources/Instructions

From Slack: Erin Dean 3:21 PM @John Darragh

@Hannah Zulueta I have had four students from UCLA. Message me some variation of this today. “Every time I hand off an assignment and request a new one, the one I hand off comes back to me. If I want to request a new assignment, I’m unable to do so.” has anything changed? I’m going to suggest a short term workaround of making the request before they hand off the old one. I was just surprised when email after email kept coming in today. (edited)

John Darragh 9:19 PM I figured out what's happening. The request assignment query was not coded exactly right, so it is only looking for Food Pantries (and Farmer's Markets, but not Meal Programs) that are not permanently closed and have a status of Needs Verification, then it picks the one with the earliest last modified date. At this time in production, you don't have any Food Pantries in the Needs Verification status that are not permanently closed (which is probably why you just started seeing this today, because you probably always had some Food Pantries that met the other criteria). So what happens is this: they hand-off a listing, which makes it the only Food Pantry that needs verification, then when they request a new assignment, it just gives the same one back to them. Your short-term workaround won't work either because there are no Food Pantries that meet the criteria, so when they try the Request Assignment button, it won't give them a new assignment at all - we should display a message when that happens to tell them that there are no listings that need verification and to check with the admin to resolve the issue. I need to do a hotfix to correct this, so the request assignment will find Food Pantries AND Meal Programs that are not permanently closed and Need Verification, which I'll try to get done tomorrow. In the meantime, you should still be able to assign Meal Programs to them from the Verification Admin Dashboard - there are currently 54 of them to work on. The hotfix will also include a fix to the problem with the "Suggest a New Listing" feature.

entrotech avatar Feb 25 '23 17:02 entrotech

Did Hotfix 1.0.71 to release to prod immediately. Also PR #1566 is slightly different (because of typsescript modifications) and merged to develop branch

entrotech avatar Feb 25 '23 17:02 entrotech

Hi — this seems to be broken again — volunteers are not being assigned listings at all but there are valid ones waiting to be vended

To recreate: 0. Using volunteer coordinator account, see that there are lots of listings meeting criteria (needs validation && (pantry|meal program) && !permanently_closed (or something like that)) waiting to be vended.

  1. Sign in with data validation account
  2. Press “Request assignment”
  3. Error: Nothing happens - no assignment comes in.

Related to

  • #1519

fancyham avatar Apr 18 '24 04:04 fancyham

Can't reproduce on 8/11/25. Request Assignment feature gets new assignments in Dev and Production environments.

entrotech avatar Aug 12 '25 04:08 entrotech

I reproduced it on my machine - Mac, Safari - on Sept 2, 2025.

Is this perhaps because I'm doing it on devla?

Video showing me trying "Request Assignment" on devla.foodoasis.net with a data entry user account

https://github.com/user-attachments/assets/74b8c447-8bbe-4cf7-8f36-0930d5794313

There are actually listings waiting to be validated, as seen here with an admin account:

Image

fancyham avatar Sep 02 '25 21:09 fancyham

@entrotech ^ Perhaps I'm doing it on the wrong site?

fancyham avatar Sep 02 '25 22:09 fancyham