VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

Address warnings for rule: arrow-body-style

Open jasonwong26 opened this issue 3 years ago • 3 comments

v0.4 Setup Infrastructure

This ticket addresses eslint warnings for rules copied from the v0.3 branch.

Instructions

  • [ ] Review the rule documentation for the rule (see reference pages below)
  • [ ] Navigate the cli to the client folder
  • [ ] Run the lint script (e.g. npm run lint)
  • [ ] Review the results, noting all instances where the rule is referenced.
  • [ ] Address each warning using one of the following options, according to your best judgement:
    • use the npx eslint --fix --rule {rule to fix} command (not available for all rules)
    • correct the code according to the recommendations listed in the rule documentation
    • disable the rule for the reported line (NOTE: only use the disable instruction for a single line. Do NOT use the more global options). Include a comment for why this decision was made.
    • raise the rule as a topic to discuss with the group in the next meeting. We can then decide whether to edit or drop the rule, add more global disable flags, etc.

Acceptance Criteria

Running the lint script should result in an output that does not mention this rule (meaning all instances either corrected or marked for ignore).

Reference

jasonwong26 avatar Aug 29 '21 21:08 jasonwong26

Navigate the cli to the client folder

The client folder doesn't have a lint script but both backend and backend-mvp-04 do. I'll continue forward with backend unless told otherwise. :)

glenflorendo avatar Sep 16 '21 04:09 glenflorendo

Hi Glen,

I recommend waiting to work on this - Alex is reviewing the PR to add the lint rules #679

jasonwong26 avatar Sep 16 '21 04:09 jasonwong26

@jasonwong26 Got it! I'll move it back to the prioritized backlog. Thanks, Jason!

glenflorendo avatar Sep 16 '21 04:09 glenflorendo